Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1647653003: [DevTools] Remove old responsive design v1 code. (Closed)

Created:
4 years, 11 months ago by dgozman
Modified:
4 years, 10 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove old responsive design v1 code. BUG=540864 Committed: https://crrev.com/2c50091b853d21a0097c52bdd9c7daf0e15e69b3 Cr-Commit-Position: refs/heads/master@{#371977}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2984 lines) Patch
M third_party/WebKit/Source/devtools/devtools.gypi View 3 chunks +0 lines, -9 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/Images/responsiveDesign.png View Binary file 0 comments Download
D third_party/WebKit/Source/devtools/front_end/Images/responsiveDesign_2x.png View Binary file 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/src/optimize_png.hashes View 1 chunk +1 line, -2 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/Images/src/responsiveDesign.svg View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/src/svg2png.hashes View 1 chunk +1 line, -2 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeButton.js View 1 chunk +0 lines, -65 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js View 2 chunks +0 lines, -42 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/emulation/OverridesSupport.js View 1 chunk +0 lines, -820 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/emulation/OverridesUI.js View 1 chunk +0 lines, -246 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/emulation/OverridesView.js View 1 chunk +0 lines, -163 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/emulation/ResponsiveDesignView.js View 1 chunk +0 lines, -890 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/module.json View 4 chunks +0 lines, -49 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/emulation/overrides.css View 1 chunk +0 lines, -217 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/emulation/responsiveDesignView.css View 1 chunk +0 lines, -436 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/AdvancedApp.js View 4 chunks +6 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 5 chunks +3 lines, -16 lines 1 comment Download
M third_party/WebKit/Source/devtools/front_end/main/Tests.js View 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
dgozman
PTAL
4 years, 11 months ago (2016-01-28 00:28:42 UTC) #2
pfeldman
lgtm
4 years, 11 months ago (2016-01-28 01:10:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647653003/1
4 years, 11 months ago (2016-01-28 01:13:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 02:56:35 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2c50091b853d21a0097c52bdd9c7daf0e15e69b3 Cr-Commit-Position: refs/heads/master@{#371977}
4 years, 11 months ago (2016-01-28 02:58:18 UTC) #8
jochen (gone - plz use gerrit)
4 years, 10 months ago (2016-02-25 11:13:34 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/1647653003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (left):

https://codereview.chromium.org/1647653003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/main/Main.js:347:
WebInspector.inspectorView.showViewInDrawer("emulation", true);
I suspect this broke the "disable javascript": setting..

Powered by Google App Engine
This is Rietveld 408576698