chrome/browser/ui/views/tabs/tab_drag_controller.cc - Issue 1637943003: Remove HostDesktopType from BrowserList::GetInstance()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller.cc

Issue 1637943003: Remove HostDesktopType from BrowserList::GetInstance() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@screen-wrapper-land

Patch Set: mac2 Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc ('k') | chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tabs/tab_drag_controller.cc

diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller.cc b/chrome/browser/ui/views/tabs/tab_drag_controller.cc

index bd8325fd2ed9e51879ae54eea95378b98f421806..1d4faf0980bde8ab58352b07b5d74aff1589bd6d 100644

--- a/chrome/browser/ui/views/tabs/tab_drag_controller.cc

+++ b/chrome/browser/ui/views/tabs/tab_drag_controller.cc

@@ -1811,12 +1811,9 @@ gfx::NativeWindow TabDragController::GetLocalProcessWindow(

// window which was used for dragging is not hidden once all of its tabs are

// attached to another browser window in DragBrowserToNewTabStrip().

// TODO(pkotwicz): Fix this properly (crbug.com/358482)

- BrowserList* browser_list = BrowserList::GetInstance(

- chrome::HOST_DESKTOP_TYPE_NATIVE);

- for (BrowserList::const_iterator it = browser_list->begin();

- it != browser_list->end(); ++it) {

- if ((*it)->tab_strip_model()->empty())

- exclude.insert((*it)->window()->GetNativeWindow());

+ for (auto& browser : *BrowserList::GetInstance()) {

+ if (browser->tab_strip_model()->empty())

+ exclude.insert(browser->window()->GetNativeWindow());

}

#endif

return GetLocalProcessWindowAtPoint(host_desktop_type_,