chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm - Issue 1637943003: Remove HostDesktopType from BrowserList::GetInstance()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm

Issue 1637943003: Remove HostDesktopType from BrowserList::GetInstance() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@screen-wrapper-land

Patch Set: mac2 Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser_tabrestore_browsertest.cc ('k') | chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm b/chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm

index a14dae56e91198eb82472ebb55bedd196dad335d..cc8c4a2228fd44a17163acdd531ab3ebd7260d78 100644

--- a/chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm

+++ b/chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm

@@ -215,9 +215,7 @@ IN_PROC_BROWSER_TEST_F(AppShimMenuControllerBrowserTest,

// Find the first hosted app window.

Browser* hosted_app_browser = nullptr;

- BrowserList* browsers =

- BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_NATIVE);

- for (Browser* browser : *browsers) {

+ for (Browser* browser : *BrowserList::GetInstance()) {

const extensions::Extension* extension =

apps::ExtensionAppShimHandler::MaybeGetAppForBrowser(browser);

if (extension && extension->is_hosted_app()) {