Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Side by Side Diff: chrome/browser/ui/browser_tab_restorer.cc

Issue 1637943003: Remove HostDesktopType from BrowserList::GetInstance() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@screen-wrapper-land
Patch Set: mac2 Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/browser_list.cc ('k') | chrome/browser/ui/browser_tab_strip_tracker.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/metrics/user_metrics_action.h" 6 #include "base/metrics/user_metrics_action.h"
7 #include "base/supports_user_data.h" 7 #include "base/supports_user_data.h"
8 #include "chrome/browser/profiles/profile.h" 8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/browser/sessions/tab_restore_service_factory.h" 9 #include "chrome/browser/sessions/tab_restore_service_factory.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 void OnBrowserRemoved(Browser* browser) override; 48 void OnBrowserRemoved(Browser* browser) override;
49 49
50 Browser* browser_; 50 Browser* browser_;
51 sessions::TabRestoreService* tab_restore_service_; 51 sessions::TabRestoreService* tab_restore_service_;
52 52
53 DISALLOW_COPY_AND_ASSIGN(BrowserTabRestorer); 53 DISALLOW_COPY_AND_ASSIGN(BrowserTabRestorer);
54 }; 54 };
55 55
56 BrowserTabRestorer::~BrowserTabRestorer() { 56 BrowserTabRestorer::~BrowserTabRestorer() {
57 tab_restore_service_->RemoveObserver(this); 57 tab_restore_service_->RemoveObserver(this);
58 BrowserList::GetInstance(browser_->host_desktop_type())->RemoveObserver(this); 58 BrowserList::GetInstance()->RemoveObserver(this);
59 } 59 }
60 60
61 // static 61 // static
62 void BrowserTabRestorer::CreateIfNecessary(Browser* browser) { 62 void BrowserTabRestorer::CreateIfNecessary(Browser* browser) {
63 DCHECK(browser); 63 DCHECK(browser);
64 if (browser->profile()->GetUserData(kBrowserTabRestorerKey)) 64 if (browser->profile()->GetUserData(kBrowserTabRestorerKey))
65 return; // Only allow one restore for a given profile at a time. 65 return; // Only allow one restore for a given profile at a time.
66 66
67 // BrowserTabRestorer is deleted at the appropriate time. 67 // BrowserTabRestorer is deleted at the appropriate time.
68 new BrowserTabRestorer(browser); 68 new BrowserTabRestorer(browser);
69 } 69 }
70 70
71 BrowserTabRestorer::BrowserTabRestorer(Browser* browser) 71 BrowserTabRestorer::BrowserTabRestorer(Browser* browser)
72 : browser_(browser), 72 : browser_(browser),
73 tab_restore_service_( 73 tab_restore_service_(
74 TabRestoreServiceFactory::GetForProfile(browser->profile())) { 74 TabRestoreServiceFactory::GetForProfile(browser->profile())) {
75 DCHECK(tab_restore_service_); 75 DCHECK(tab_restore_service_);
76 DCHECK(!tab_restore_service_->IsLoaded()); 76 DCHECK(!tab_restore_service_->IsLoaded());
77 tab_restore_service_->AddObserver(this); 77 tab_restore_service_->AddObserver(this);
78 BrowserList::GetInstance(browser->host_desktop_type())->AddObserver(this); 78 BrowserList::GetInstance()->AddObserver(this);
79 browser_->profile()->SetUserData(kBrowserTabRestorerKey, this); 79 browser_->profile()->SetUserData(kBrowserTabRestorerKey, this);
80 tab_restore_service_->LoadTabsFromLastSession(); 80 tab_restore_service_->LoadTabsFromLastSession();
81 } 81 }
82 82
83 void BrowserTabRestorer::TabRestoreServiceChanged( 83 void BrowserTabRestorer::TabRestoreServiceChanged(
84 sessions::TabRestoreService* service) {} 84 sessions::TabRestoreService* service) {}
85 85
86 void BrowserTabRestorer::TabRestoreServiceDestroyed( 86 void BrowserTabRestorer::TabRestoreServiceDestroyed(
87 sessions::TabRestoreService* service) {} 87 sessions::TabRestoreService* service) {}
88 88
(...skipping 21 matching lines...) Expand all
110 if (service->IsLoaded()) { 110 if (service->IsLoaded()) {
111 service->RestoreMostRecentEntry(browser->live_tab_context(), 111 service->RestoreMostRecentEntry(browser->live_tab_context(),
112 browser->host_desktop_type()); 112 browser->host_desktop_type());
113 return; 113 return;
114 } 114 }
115 115
116 BrowserTabRestorer::CreateIfNecessary(browser); 116 BrowserTabRestorer::CreateIfNecessary(browser);
117 } 117 }
118 118
119 } // namespace chrome 119 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser_list.cc ('k') | chrome/browser/ui/browser_tab_strip_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698