Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1637793003: clang/win: Fix -Wsign-compare warning after https://codereview.chromium.org/1631903002 (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, gab, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Fix -Wsign-compare warning after https://codereview.chromium.org/1631903002 Also turn on chromium_code for these targets in gyp. This makes warnings for these targets consistent between gyp and gn. BUG=550983, 581133, 82385 TBR=grt@chromium.org Committed: https://crrev.com/80a9d9b6ec09e3565f3a509bf0dde3509e61e451 Cr-Commit-Position: refs/heads/master@{#371520}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/installer/test/alternate_version_generator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/upgrade_test.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
4 years, 11 months ago (2016-01-26 15:42:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637793003/1
4 years, 11 months ago (2016-01-26 15:42:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 16:03:19 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/80a9d9b6ec09e3565f3a509bf0dde3509e61e451 Cr-Commit-Position: refs/heads/master@{#371520}
4 years, 11 months ago (2016-01-26 16:04:16 UTC) #6
grt (UTC plus 2)
4 years, 11 months ago (2016-01-26 16:41:15 UTC) #7
Message was sent while issue was closed.
lgtm. thanks!

Powered by Google App Engine
This is Rietveld 408576698