chrome/installer/test/alternate_version_generator.cc - Issue 1637793003: clang/win: Fix -Wsign-compare warning after https://codereview.chromium.org/1631903002

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/test/alternate_version_generator.cc

Issue 1637793003: clang/win: Fix -Wsign-compare warning after https://codereview.chromium.org/1631903002 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/test/alternate_version_generator.cc

diff --git a/chrome/installer/test/alternate_version_generator.cc b/chrome/installer/test/alternate_version_generator.cc

index c0ec33334b4d7a5ff3242008ed091314ba42838e..211b1e547322f373f361a7426a8a0e020cae6eb0 100644

--- a/chrome/installer/test/alternate_version_generator.cc

+++ b/chrome/installer/test/alternate_version_generator.cc

@@ -425,8 +425,8 @@ bool UpdateManifestVersion(const base::FilePath& manifest,

return false;

}

DCHECK(modified);

- return base::WriteFile(manifest, &contents[0], contents.size()) ==

- contents.size();

+ int written = base::WriteFile(manifest, &contents[0], contents.size());

+ return written != -1 && static_cast<size_t>(written) == contents.size();

}

bool IncrementNewVersion(upgrade_test::Direction direction,

« no previous file with comments | « no previous file | chrome/installer/upgrade_test.gyp » ('j') | no next file with comments »