Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1631903002: Add support for component builds in alternate_version_generator. (Closed)

Created:
4 years, 11 months ago by grt (UTC plus 2)
Modified:
4 years, 11 months ago
Reviewers:
gab
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for component builds in alternate_version_generator. BUG=550983, 581133 Committed: https://crrev.com/4540853f2b2322700f27f184186c509e2b3e724f Cr-Commit-Position: refs/heads/master@{#371398}

Patch Set 1 #

Total comments: 16

Patch Set 2 : gab comments #

Patch Set 3 : string16 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -70 lines) Patch
M chrome/installer/test/alternate_version_generator.cc View 1 2 19 chunks +133 lines, -69 lines 0 comments Download
M chrome/installer/test/resource_updater.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
grt (UTC plus 2)
This seems to do the trick. PTAL.
4 years, 11 months ago (2016-01-25 18:57:38 UTC) #2
gab
Nice :-), lgtm with comments below. PS: How is this tested? Or is the test ...
4 years, 11 months ago (2016-01-25 21:00:12 UTC) #3
grt (UTC plus 2)
Thanks! As mentioned, this is un-tested, but I hope to use it in some integration ...
4 years, 11 months ago (2016-01-26 00:13:45 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631903002/20001
4 years, 11 months ago (2016-01-26 00:15:09 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/138848)
4 years, 11 months ago (2016-01-26 00:28:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631903002/40001
4 years, 11 months ago (2016-01-26 00:53:41 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-26 01:16:20 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 01:18:33 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4540853f2b2322700f27f184186c509e2b3e724f
Cr-Commit-Position: refs/heads/master@{#371398}

Powered by Google App Engine
This is Rietveld 408576698