Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: chrome/installer/upgrade_test.gyp

Issue 1637793003: clang/win: Fix -Wsign-compare warning after https://codereview.chromium.org/1631903002 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/installer/test/alternate_version_generator.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'chromium_code': 1,
7 'branding_dir': '../app/theme/<(branding_path_component)', 8 'branding_dir': '../app/theme/<(branding_path_component)',
8 'version_py': '<(DEPTH)/build/util/version.py', 9 'version_py': '<(DEPTH)/build/util/version.py',
9 'version_path': '../../chrome/VERSION', 10 'version_path': '../../chrome/VERSION',
10 'lastchange_path': '<(DEPTH)/build/util/LASTCHANGE', 11 'lastchange_path': '<(DEPTH)/build/util/LASTCHANGE',
11 # 'branding_dir' is set in the 'conditions' section at the bottom. 12 # 'branding_dir' is set in the 'conditions' section at the bottom.
12 'msvs_use_common_release': 0, 13 'msvs_use_common_release': 0,
13 'msvs_use_common_linker_extras': 0, 14 'msvs_use_common_linker_extras': 0,
14 }, 15 },
15 'includes': [ 16 'includes': [
16 '../../build/win_precompile.gypi', 17 '../../build/win_precompile.gypi',
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 'sources': [ 87 'sources': [
87 'test/alternate_version_generator_main.cc', 88 'test/alternate_version_generator_main.cc',
88 ], 89 ],
89 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. 90 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
90 'msvs_disabled_warnings': [ 4267, ], 91 'msvs_disabled_warnings': [ 4267, ],
91 }, 92 },
92 ], 93 ],
93 }], 94 }],
94 ], 95 ],
95 } 96 }
OLDNEW
« no previous file with comments | « chrome/installer/test/alternate_version_generator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698