blink: Fix naming and const-ness of constants and non-constants.

blink: Fix naming and const-ness of constants and non-constants.

If a variable is named kFoo it should be a compile-time constant, and
vice versa. Make these match by making variables actually be const, or
by changing the name if they are not compile-time constant.

R=pdr
BUG=580743
Committed: https://crrev.com/1305f726bd299d30b0206bdd787eda473be7cce3
Cr-Commit-Position: refs/heads/master@{#371680}

[danakj, 2016-01-26 22:56:19]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 22:57:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1636873005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1636873005/1

[danakj, 2016-01-26 23:02:41]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-01-26 23:04:02]

https://codereview.chromium.org/1636873005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/SubresourceIntegrityTest.cpp (left):

https://codereview.chromium.org/1636873005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/SubresourceIntegrityTest.cpp:312:
{"XVVXBGoYw6AJOh9J+Z8pBDMVVPfkBpngexkA7JqZu8d5GENND6TEIup/tA1v5GPr",
HashAlgorithmSha384},
This looks like it's doing struct initialization, but guess what it's not, it's
calling a constructor with {}s which is not allowed. Also it could have side
effects though it looks like it can't, cool right?

[danakj, 2016-01-26 23:05:53]

danakj@chromium.org changed reviewers:
+ kbr@chromium.org

[danakj, 2016-01-26 23:05:53]

+kbr for the Source/modules changes

[Ken Russell (switch to Gerrit), 2016-01-26 23:08:29]

Source/modules lgtm

[commit-bot: I haz the power, 2016-01-26 23:08:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1636873005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1636873005/20001

[danakj, 2016-01-26 23:09:40]

danakj@chromium.org changed reviewers:
+ bashi@chromium.org

[danakj, 2016-01-26 23:09:41]

+thakis for wtf/
+bashi for bindings/

[danakj, 2016-01-26 23:10:00]

Description was changed from

==========
blink: Fix naming and const-ness of constants and non-constants.

If a variable is named kFoo it should be a compile-time constant, and
vice versa. Make these match by making variables actually be const, or
by changing the name if they are not compile-time constant.

R=pdr
BUG=580743
==========

to

==========
blink: Fix naming and const-ness of constants and non-constants.

If a variable is named kFoo it should be a compile-time constant, and
vice versa. Make these match by making variables actually be const, or
by changing the name if they are not compile-time constant.

R=pdr
BUG=580743
==========

[danakj, 2016-01-26 23:10:00]

danakj@chromium.org changed reviewers:
+ thakis@chromium.org

[pdr., 2016-01-26 23:22:18]

LGTM for everything except wtf and bindings.

[Peter Kasting, 2016-01-26 23:23:11]

https://codereview.chromium.org/1636873005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/experiments/Experiments.cpp (right):

https://codereview.chromium.org/1636873005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/experiments/Experiments.cpp:20: const char
kExperimentsMetaName[] = "api-experiments";
Bogus indenting?  (And this is not the only file where such a change occurs.)

[danakj, 2016-01-26 23:36:18]

https://codereview.chromium.org/1636873005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/experiments/Experiments.cpp (right):

https://codereview.chromium.org/1636873005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/experiments/Experiments.cpp:20: const char
kExperimentsMetaName[] = "api-experiments";
On 2016/01/26 23:23:11, Peter Kasting wrote:
> Bogus indenting?  (And this is not the only file where such a change occurs.)

Huh, ya clang-format doing it wrong here. I can override it and file a bug
(maybe it doesn't matter that much since blink-style is going away soon and this
works in chromium style).

[haraken, 2016-01-26 23:41:46]

bindings/ and wtf/ LGTM

[danakj, 2016-01-26 23:43:13]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-01-26 23:43:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, kbr@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1636873005/#ps40001
(title: "constants: indents")

[commit-bot: I haz the power, 2016-01-26 23:45:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1636873005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1636873005/40001

[danakj, 2016-01-26 23:48:31]

On Tue, Jan 26, 2016 at 3:41 PM, <haraken@chromium.org> wrote:

> bindings/ and wtf/ LGTM
>

thanks :)

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[danakj, 2016-01-26 23:50:04]

On Tue, Jan 26, 2016 at 3:41 PM, <haraken@chromium.org> wrote:

> bindings/ and wtf/ LGTM
>

thanks :)

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-01-27 01:38:38]

Description was changed from

==========
blink: Fix naming and const-ness of constants and non-constants.

If a variable is named kFoo it should be a compile-time constant, and
vice versa. Make these match by making variables actually be const, or
by changing the name if they are not compile-time constant.

R=pdr
BUG=580743
==========

to

==========
blink: Fix naming and const-ness of constants and non-constants.

If a variable is named kFoo it should be a compile-time constant, and
vice versa. Make these match by making variables actually be const, or
by changing the name if they are not compile-time constant.

R=pdr
BUG=580743
==========

[commit-bot: I haz the power, 2016-01-27 01:38:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-27 01:39:34]

Description was changed from

==========
blink: Fix naming and const-ness of constants and non-constants.

If a variable is named kFoo it should be a compile-time constant, and
vice versa. Make these match by making variables actually be const, or
by changing the name if they are not compile-time constant.

R=pdr
BUG=580743
==========

to

==========
blink: Fix naming and const-ness of constants and non-constants.

If a variable is named kFoo it should be a compile-time constant, and
vice versa. Make these match by making variables actually be const, or
by changing the name if they are not compile-time constant.

R=pdr
BUG=580743

Committed: https://crrev.com/1305f726bd299d30b0206bdd787eda473be7cce3
Cr-Commit-Position: refs/heads/master@{#371680}
==========

[commit-bot: I haz the power, 2016-01-27 01:39:35]

Patchset 3 (id:??) landed as
https://crrev.com/1305f726bd299d30b0206bdd787eda473be7cce3
Cr-Commit-Position: refs/heads/master@{#371680}