third_party/WebKit/Source/platform/exported/linux/WebFontInfo.cpp - Issue 1636873005: blink: Fix naming and const-ness of constants and non-constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/linux/WebFontInfo.cpp

Issue 1636873005: blink: Fix naming and const-ness of constants and non-constants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: constants: indents Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/exported/WebMediaConstraints.cpp ('k') | third_party/WebKit/Source/platform/fonts/CharacterEmoji.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/exported/linux/WebFontInfo.cpp

diff --git a/third_party/WebKit/Source/platform/exported/linux/WebFontInfo.cpp b/third_party/WebKit/Source/platform/exported/linux/WebFontInfo.cpp

index 681c977a1188a71ff9f20259b52d30ce74796806..62bfc6498240e4fd491878b0b0903c1d739e57da 100644

--- a/third_party/WebKit/Source/platform/exported/linux/WebFontInfo.cpp

+++ b/third_party/WebKit/Source/platform/exported/linux/WebFontInfo.cpp

@@ -233,14 +233,14 @@ public:

WebFallbackFont fallbackFontForCharInLocale(WebUChar32 c, const char* locale)

{

- DEFINE_STATIC_LOCAL(AtomicString, kNoLocale, ("NO_LOCALE_SPECIFIED", AtomicString::ConstructFromLiteral));

+ DEFINE_STATIC_LOCAL(AtomicString, noLocale, ("NO_LOCALE_SPECIFIED", AtomicString::ConstructFromLiteral));

AtomicString localeKey;

if (locale && strlen(locale)) {

localeKey = AtomicString(locale);

} else {

// String hash computation the m_setsByLocale map needs

// a non-empty string.

- localeKey = kNoLocale;

+ localeKey = noLocale;

}

LocaleToCachedFont::iterator itr = m_setsByLocale.find(localeKey);