third_party/WebKit/Source/core/experiments/ExperimentsTest.cpp - Issue 1636873005: blink: Fix naming and const-ness of constants and non-constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/experiments/ExperimentsTest.cpp

Issue 1636873005: blink: Fix naming and const-ness of constants and non-constants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: constants: indents Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/experiments/Experiments.cpp ('k') | third_party/WebKit/Source/core/frame/SubresourceIntegrityTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/experiments/ExperimentsTest.cpp

diff --git a/third_party/WebKit/Source/core/experiments/ExperimentsTest.cpp b/third_party/WebKit/Source/core/experiments/ExperimentsTest.cpp

index 1be05eee22568f0e2bed203284a26bdb4743673e..aa90cf64940656f484d1b103cbeda0ac9d934187 100644

--- a/third_party/WebKit/Source/core/experiments/ExperimentsTest.cpp

+++ b/third_party/WebKit/Source/core/experiments/ExperimentsTest.cpp

@@ -20,13 +20,13 @@

namespace blink {

namespace {

-const char* kNonExistingAPIName = "This API does not exist";

-const char* kFrobulateAPIName = "Frobulate";

-const char* kFrobulateEnabledOrigin = "https://www.example.com";

-const char* kFrobulateEnabledOriginUnsecure = "http://www.example.com";

+const char kNonExistingAPIName[] = "This API does not exist";

+const char kFrobulateAPIName[] = "Frobulate";

+const char kFrobulateEnabledOrigin[] = "https://www.example.com";

+const char kFrobulateEnabledOriginUnsecure[] = "http://www.example.com";

-// API Key which will appear valid

-const char* kGoodAPIKey = "AnySignatureWillDo|https://www.example.com|Frobulate|2000000000";

+// API Key that will appear valid.

+const char kGoodAPIKey[] = "AnySignatureWillDo|https://www.example.com|Frobulate|2000000000";

class MockApiKeyValidator : public WebApiKeyValidator {

public: