Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 1636873005: blink: Fix naming and const-ness of constants and non-constants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: constants: indents Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index ff330cdf7300e65f08184913904f6fa42c02805b..8290f432b2e66175bb0a6805e02215c38c1997ed 100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -521,7 +521,7 @@ TEST_F(WebViewTest, SetBaseBackgroundColor)
EXPECT_EQ(kTransparent, frame->view()->baseBackgroundColor());
frame->view()->dispose();
- Color kTransparentRed(100, 0, 0, 0);
+ const Color kTransparentRed(100, 0, 0, 0);
frame->createView(IntSize(1024, 768), kTransparentRed, true);
EXPECT_EQ(kTransparentRed, frame->view()->baseBackgroundColor());
frame->view()->dispose();
@@ -2101,8 +2101,8 @@ TEST_F(WebViewTest, DispatchesFocusBlurOnViewToggle)
TEST_F(WebViewTest, SmartClipData)
{
- static const char* kExpectedClipText = "\nPrice 10,000,000won";
- static const char* kExpectedClipHtml =
+ static const char kExpectedClipText[] = "\nPrice 10,000,000won";
+ static const char kExpectedClipHtml[] =
"<div id=\"div4\" style=\"padding: 10px; margin: 10px; border: 2px "
"solid skyblue; float: left; width: 190px; height: 30px; "
"color: rgb(0, 0, 0); font-family: myahem; font-size: 8px; font-style: "
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | third_party/WebKit/Source/wtf/PartitionAllocTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698