Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1636563003: Put rare PaintLayer fields into PaintLayerRareData (Closed)

Created:
4 years, 11 months ago by Xianzhu
Modified:
4 years, 10 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Put rare PaintLayer fields into PaintLayerRareData Rare rates of the fields, based on top 10k sites (See run 475 in http://ct.skia.org for details): stackingNode 100.00% ancestorDependentCompositingInputs 82.17% clipper 36.25% staticBlockPosition 11.00% staticInlinePosition 7.49% (The following fields are put into PaintLayerRareData) potentialCompositingReasonsFromStyle 7.13% (^this is likely to cover most of the following) compositingReasons 5.77% compositedLayerMapping 3.32% subpixelAccumulation 2.86% offsetForInFlowPosition 2.70% grouppedMapping 2.35% transform 2.02% enclosingPaginationLayer 0.01% reflectionInfo (count) 0.00% blockSelectionGapsBounds 0.00% AncestorDependentCompositingInputs fields: clippedAbsoluteBoundingBox 69.73% clippingContainer 46.57% (The following fields are put into RareAncestorDependentCompositingInputs) transformAncestor 6.14% opacityAncestor 4.73% ancestorScrollingLayer 4.26% scrollParent 2.76% nearestFixedPositionLayer 2.31% filterAncestor 0.02% Rare rate of a field is defined as: number of PaintLayers with the field ever assigned non-default value / total number of PaintLayers. This CL reduces sizeof(PaintLayer) from 344 bytes to 208 bytes on LP 64 systems. BUG=581124 Committed: https://crrev.com/299d5beba4af85652d96a2b2da1733ebcdec2c5e Cr-Commit-Position: refs/heads/master@{#372141}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : Rebaser #

Patch Set 7 : #

Total comments: 4

Patch Set 8 : #

Patch Set 9 : Rebase #

Total comments: 6

Patch Set 10 : #

Messages

Total messages: 26 (10 generated)
Xianzhu
Cluster telemetry result (Run 486 http://ct.skia.org) shows that the patch slightly improves record_time (by 0.39%~1.6%). ...
4 years, 11 months ago (2016-01-27 19:47:07 UTC) #5
chrishtr
Please post rasterize_and_record_micro timings from Cluster Telemetry on this patch, excited to see the results. ...
4 years, 11 months ago (2016-01-27 23:55:57 UTC) #6
Xianzhu
https://codereview.chromium.org/1636563003/diff/120001/third_party/WebKit/Source/core/paint/PaintLayer.h File third_party/WebKit/Source/core/paint/PaintLayer.h (right): https://codereview.chromium.org/1636563003/diff/120001/third_party/WebKit/Source/core/paint/PaintLayer.h#newcode119 third_party/WebKit/Source/core/paint/PaintLayer.h:119: OwnPtr<CompositedLayerMapping> compositedLayerMapping; On 2016/01/27 23:55:57, chrishtr wrote: > Briefly ...
4 years, 11 months ago (2016-01-28 02:54:24 UTC) #7
chrishtr
Any update on cluster telemetry?
4 years, 10 months ago (2016-01-28 16:45:08 UTC) #8
Xianzhu
On 2016/01/28 16:45:08, chrishtr wrote: > Any update on cluster telemetry? Repeated additional twice on ...
4 years, 10 months ago (2016-01-28 16:55:24 UTC) #9
chrishtr
lgtm https://codereview.chromium.org/1636563003/diff/160001/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h File third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h (right): https://codereview.chromium.org/1636563003/diff/160001/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h#newcode75 third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h:75: // the layer is squashed; s/layer/PaintLayer/ https://codereview.chromium.org/1636563003/diff/160001/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h#newcode76 third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h:76: ...
4 years, 10 months ago (2016-01-28 18:04:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636563003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636563003/160001
4 years, 10 months ago (2016-01-28 18:05:28 UTC) #12
chrishtr
(removed commit since I had a couple of small comments)
4 years, 10 months ago (2016-01-28 18:16:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636563003/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636563003/180001
4 years, 10 months ago (2016-01-28 18:25:29 UTC) #17
Xianzhu
https://codereview.chromium.org/1636563003/diff/160001/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h File third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h (right): https://codereview.chromium.org/1636563003/diff/160001/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h#newcode75 third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h:75: // the layer is squashed; On 2016/01/28 18:04:29, chrishtr ...
4 years, 10 months ago (2016-01-28 18:30:30 UTC) #18
chrishtr
On 2016/01/28 at 18:30:30, wangxianzhu wrote: > https://codereview.chromium.org/1636563003/diff/160001/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h > File third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h (right): > > https://codereview.chromium.org/1636563003/diff/160001/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h#newcode75 ...
4 years, 10 months ago (2016-01-28 18:33:52 UTC) #19
Xianzhu
On 2016/01/28 18:33:52, chrishtr wrote: > On 2016/01/28 at 18:30:30, wangxianzhu wrote: > > > ...
4 years, 10 months ago (2016-01-28 18:44:53 UTC) #20
chrishtr
lgtm
4 years, 10 months ago (2016-01-28 18:56:02 UTC) #21
commit-bot: I haz the power
Committed patchset #10 (id:180001)
4 years, 10 months ago (2016-01-28 19:36:35 UTC) #23
commit-bot: I haz the power
Patchset 10 (id:??) landed as https://crrev.com/299d5beba4af85652d96a2b2da1733ebcdec2c5e Cr-Commit-Position: refs/heads/master@{#372141}
4 years, 10 months ago (2016-01-28 19:38:47 UTC) #25
haraken
4 years, 10 months ago (2016-01-29 08:29:04 UTC) #26
Message was sent while issue was closed.
I'm not 100% sure but it looks like this CL caused leaks in the following tests:

fast/css/getComputedStyle/computed-style-with-zoom.html
cssom/cssvalue-comparison.html

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...

Powered by Google App Engine
This is Rietveld 408576698