third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp - Issue 1636563003: Put rare PaintLayer fields into PaintLayerRareData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp

Issue 1636563003: Put rare PaintLayer fields into PaintLayerRareData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp ('k') | third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp

index 35daf9f01922cfb614ed18b6f7887261e355491a..873ec4b5fd101c78e09ce1c5865c6cd95fda0a37 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp

@@ -159,19 +159,16 @@ CompositingReasons CompositingLayerAssigner::getReasonsPreventingSquashing(const

if (layer->scrollParent() && layer->hasCompositingDescendant())

return CompositingReasonScrollChildWithCompositedDescendants;

- const PaintLayer::AncestorDependentCompositingInputs& compositingInputs = layer->ancestorDependentCompositingInputs();

- const PaintLayer::AncestorDependentCompositingInputs& squashingLayerCompositingInputs = squashingLayer.ancestorDependentCompositingInputs();

- if (compositingInputs.opacityAncestor != squashingLayerCompositingInputs.opacityAncestor)

+ if (layer->opacityAncestor() != squashingLayer.opacityAncestor())

return CompositingReasonSquashingOpacityAncestorMismatch;

- if (compositingInputs.transformAncestor != squashingLayerCompositingInputs.transformAncestor)

+ if (layer->transformAncestor() != squashingLayer.transformAncestor())

return CompositingReasonSquashingTransformAncestorMismatch;

- if (layer->hasFilter() || compositingInputs.filterAncestor != squashingLayerCompositingInputs.filterAncestor)

+ if (layer->hasFilter() || layer->filterAncestor() != squashingLayer.filterAncestor())

return CompositingReasonSquashingFilterMismatch;

- if (compositingInputs.nearestFixedPositionLayer != squashingLayerCompositingInputs.nearestFixedPositionLayer)

+ if (layer->nearestFixedPositionLayer() != squashingLayer.nearestFixedPositionLayer())

return CompositingReasonSquashingNearestFixedPositionMismatch;

ASSERT(layer->layoutObject()->style()->position() != FixedPosition);