Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1616193002:
Add size check for PaintLayer (Closed)
|
Created:
4 years, 11 months ago by Xianzhu Modified:
4 years, 11 months ago Reviewers:
chrishtr CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd size check for PaintLayer
Committed: https://crrev.com/da42a3f1bb4756fb35f7ce4f90064f29eee87946
Cr-Commit-Position: refs/heads/master@{#371103}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : Show size #Patch Set 4 : Exclude windows #Messages
Total messages: 19 (8 generated)
wangxianzhu@chromium.org changed reviewers: + chrishtr@chromium.org
It's already very big: 336 bytes on LP64.
The CQ bit was checked by chrishtr@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616193002/20001
On 2016/01/21 at 23:42:34, wangxianzhu wrote: > It's already very big: 336 bytes on LP64. Sad times. We should do an audit to see if anything is redundant.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by wangxianzhu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from chrishtr@chromium.org Link to the patchset: https://codereview.chromium.org/1616193002/#ps60001 (title: "Exclude windows")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616193002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616193002/60001
The CQ bit was unchecked by wangxianzhu@chromium.org
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616193002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616193002/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Add size check for PaintLayer ========== to ========== Add size check for PaintLayer Committed: https://crrev.com/da42a3f1bb4756fb35f7ce4f90064f29eee87946 Cr-Commit-Position: refs/heads/master@{#371103} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/da42a3f1bb4756fb35f7ce4f90064f29eee87946 Cr-Commit-Position: refs/heads/master@{#371103}
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1622593003/ by shess@chromium.org. The reason for reverting is: "Chromium Webkit WebKit Linux Oilpan Builder failure" https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan... ../../third_party/WebKit/Source/core/paint/PaintLayer.cpp:125:1: error: static_assert failed "PaintLayer should stay small" static_assert(sizeof(PaintLayer) == sizeof(SameSizeAsPaintLayer), "PaintLayer should stay small"); . |
