third_party/WebKit/Source/core/inspector/InjectedScriptHost.cpp - Issue 1636223002: DevTools: remove ScriptState/Value from the InjectedScript APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InjectedScriptHost.cpp

Issue 1636223002: DevTools: remove ScriptState/Value from the InjectedScript APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InjectedScriptHost.h ('k') | third_party/WebKit/Source/core/inspector/InjectedScriptManager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InjectedScriptHost.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InjectedScriptHost.cpp b/third_party/WebKit/Source/core/inspector/InjectedScriptHost.cpp

index 9ffb552014f6e22ff9e481e93e1902344e6d69ed..12cf288305cf0c0a838fd7f42a07af4b066e1b9b 100644

--- a/third_party/WebKit/Source/core/inspector/InjectedScriptHost.cpp

+++ b/third_party/WebKit/Source/core/inspector/InjectedScriptHost.cpp

@@ -81,9 +81,9 @@ void InjectedScriptHost::clearConsoleMessages()

(*m_clearConsoleCallback)();

}

-ScriptValue InjectedScriptHost::InspectableObject::get(ScriptState*)

+v8::Local<v8::Value> InjectedScriptHost::InspectableObject::get(v8::Local<v8::Context>)

{

- return ScriptValue();

+ return v8::Local<v8::Value>();

};

void InjectedScriptHost::addInspectedObject(PassOwnPtr<InjectedScriptHost::InspectableObject> object)