Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: third_party/WebKit/Source/core/inspector/InjectedScriptManager.h

Issue 1636223002: DevTools: remove ScriptState/Value from the InjectedScript APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InjectedScriptManager.h
diff --git a/third_party/WebKit/Source/core/inspector/InjectedScriptManager.h b/third_party/WebKit/Source/core/inspector/InjectedScriptManager.h
index 7ff8c3146c1ddf18465569bcf7c8022530e7ad34..1ce120561db7a3e9abcbf981602b00f8118927ff 100644
--- a/third_party/WebKit/Source/core/inspector/InjectedScriptManager.h
+++ b/third_party/WebKit/Source/core/inspector/InjectedScriptManager.h
@@ -30,7 +30,6 @@
#ifndef InjectedScriptManager_h
#define InjectedScriptManager_h
-#include "bindings/core/v8/ScriptState.h"
#include "core/CoreExport.h"
#include "wtf/Forward.h"
#include "wtf/HashMap.h"
@@ -43,7 +42,6 @@ class InjectedScript;
class InjectedScriptHost;
class InjectedScriptNative;
class RemoteObjectIdBase;
-class ScriptValue;
class V8DebuggerClient;
class CORE_EXPORT InjectedScriptManager {
@@ -57,22 +55,19 @@ public:
InjectedScriptHost* injectedScriptHost();
- InjectedScript* injectedScriptFor(ScriptState*);
+ InjectedScript* injectedScriptFor(v8::Local<v8::Context>);
InjectedScript* findInjectedScript(int) const;
InjectedScript* findInjectedScript(RemoteObjectIdBase*) const;
void discardInjectedScripts();
- int discardInjectedScriptFor(ScriptState*);
+ int discardInjectedScriptFor(v8::Local<v8::Context>);
void releaseObjectGroup(const String& objectGroup);
-
- typedef bool (*InspectedStateAccessCheck)(ScriptState*);
-
void setCustomObjectFormatterEnabled(bool);
private:
explicit InjectedScriptManager(V8DebuggerClient*);
String injectedScriptSource();
- ScriptValue createInjectedScript(const String& source, ScriptState*, int id, InjectedScriptNative*);
+ v8::Local<v8::Object> createInjectedScript(const String& source, v8::Local<v8::Context>, int id, InjectedScriptNative*);
typedef HashMap<int, OwnPtr<InjectedScript>> IdToInjectedScriptMap;
IdToInjectedScriptMap m_idToInjectedScript;

Powered by Google App Engine
This is Rietveld 408576698