Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: third_party/WebKit/Source/core/inspector/InjectedScriptHost.cpp

Issue 1636223002: DevTools: remove ScriptState/Value from the InjectedScript APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com> 3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
4 * Copyright (C) 2010 Google Inc. All rights reserved. 4 * Copyright (C) 2010 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 (*m_inspectCallback)(remoteObject, hints->asObject()); 74 (*m_inspectCallback)(remoteObject, hints->asObject());
75 } 75 }
76 } 76 }
77 77
78 void InjectedScriptHost::clearConsoleMessages() 78 void InjectedScriptHost::clearConsoleMessages()
79 { 79 {
80 if (m_clearConsoleCallback) 80 if (m_clearConsoleCallback)
81 (*m_clearConsoleCallback)(); 81 (*m_clearConsoleCallback)();
82 } 82 }
83 83
84 ScriptValue InjectedScriptHost::InspectableObject::get(ScriptState*) 84 v8::Local<v8::Value> InjectedScriptHost::InspectableObject::get(v8::Local<v8::Co ntext>)
85 { 85 {
86 return ScriptValue(); 86 return v8::Local<v8::Value>();
87 }; 87 };
88 88
89 void InjectedScriptHost::addInspectedObject(PassOwnPtr<InjectedScriptHost::Inspe ctableObject> object) 89 void InjectedScriptHost::addInspectedObject(PassOwnPtr<InjectedScriptHost::Inspe ctableObject> object)
90 { 90 {
91 m_inspectedObjects.prepend(object); 91 m_inspectedObjects.prepend(object);
92 while (m_inspectedObjects.size() > 5) 92 while (m_inspectedObjects.size() > 5)
93 m_inspectedObjects.removeLast(); 93 m_inspectedObjects.removeLast();
94 } 94 }
95 95
96 void InjectedScriptHost::clearInspectedObjects() 96 void InjectedScriptHost::clearInspectedObjects()
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 m_debuggerAgent->setBreakpoint(scriptId, lineNumber, columnNumber, V8Deb uggerAgent::MonitorCommandBreakpointSource, builder.toString()); 130 m_debuggerAgent->setBreakpoint(scriptId, lineNumber, columnNumber, V8Deb uggerAgent::MonitorCommandBreakpointSource, builder.toString());
131 } 131 }
132 132
133 void InjectedScriptHost::unmonitorFunction(const String& scriptId, int lineNumbe r, int columnNumber) 133 void InjectedScriptHost::unmonitorFunction(const String& scriptId, int lineNumbe r, int columnNumber)
134 { 134 {
135 if (m_debuggerAgent) 135 if (m_debuggerAgent)
136 m_debuggerAgent->removeBreakpoint(scriptId, lineNumber, columnNumber, V8 DebuggerAgent::MonitorCommandBreakpointSource); 136 m_debuggerAgent->removeBreakpoint(scriptId, lineNumber, columnNumber, V8 DebuggerAgent::MonitorCommandBreakpointSource);
137 } 137 }
138 138
139 } // namespace blink 139 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698