third_party/WebKit/Source/core/inspector/InjectedScriptHost.h - Issue 1636223002: DevTools: remove ScriptState/Value from the InjectedScript APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InjectedScriptHost.h

Issue 1636223002: DevTools: remove ScriptState/Value from the InjectedScript APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InjectedScript.cpp ('k') | third_party/WebKit/Source/core/inspector/InjectedScriptHost.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InjectedScriptHost.h

diff --git a/third_party/WebKit/Source/core/inspector/InjectedScriptHost.h b/third_party/WebKit/Source/core/inspector/InjectedScriptHost.h

index 4c92542698c0b84455a275920fcf6a7854499f8e..057a0ce21396667a8cd4b0494730c51746beb55b 100644

--- a/third_party/WebKit/Source/core/inspector/InjectedScriptHost.h

+++ b/third_party/WebKit/Source/core/inspector/InjectedScriptHost.h

@@ -79,7 +79,7 @@ public:

class InspectableObject {

USING_FAST_MALLOC(InspectableObject);

public:

- virtual ScriptValue get(ScriptState*);

+ virtual v8::Local<v8::Value> get(v8::Local<v8::Context>);

virtual ~InspectableObject() { }

};

void addInspectedObject(PassOwnPtr<InspectableObject>);