Introduce MultiWindowUtils#isLegacyMultiWindow()

Introduce MultiWindowUtils#isLegacyMultiWindow()

MultiWindowUtils#isLecacyMultiWindow() will check for old multi-window
mode (e.g. Samsung's multi-window mode), and #isMultiWindow() will check
for Android N multi-window.

BUG=570741
Committed: https://crrev.com/16920f1d78f2f2777c16779fa6ed4d83225282c0
Cr-Commit-Position: refs/heads/master@{#371631}

[Theresa, 2016-01-26 02:41:05]

twellington@chromium.org changed reviewers:
+ newt@chromium.org

[Theresa, 2016-01-26 02:41:06]

ptal

[newt (away), 2016-01-26 17:46:30]

https://codereview.chromium.org/1633763003/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
(right):

https://codereview.chromium.org/1633763003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java:211:
return activity != null && (
Why / do we need to disable keyboard tracking in multiwindow mode?

https://codereview.chromium.org/1633763003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java
(right):

https://codereview.chromium.org/1633763003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java:44:
* @return Whether or not {@code activity} is currently in multi-window mode.
for clarity, I'd say "Android N+ multi-window mode"

[Theresa, 2016-01-26 19:12:55]

https://codereview.chromium.org/1633763003/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
(right):

https://codereview.chromium.org/1633763003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java:211:
return activity != null && (
On 2016/01/26 17:46:30, newt wrote:
> Why / do we need to disable keyboard tracking in multiwindow mode?

Changed this to just check isLegacyMultiWindow() per our offline discussion.

https://codereview.chromium.org/1633763003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java
(right):

https://codereview.chromium.org/1633763003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java:44:
* @return Whether or not {@code activity} is currently in multi-window mode.
On 2016/01/26 17:46:30, newt wrote:
> for clarity, I'd say "Android N+ multi-window mode"

Done.

[newt (away), 2016-01-26 21:30:24]

lgtm

[Theresa, 2016-01-26 23:07:46]

The CQ bit was checked by twellington@chromium.org

[commit-bot: I haz the power, 2016-01-26 23:08:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1633763003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1633763003/20001

[commit-bot: I haz the power, 2016-01-26 23:18:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-26 23:19:42]

Description was changed from

==========
Introduce MultiWindowUtils#isLegacyMultiWindow()

MultiWindowUtils#isLecacyMultiWindow() will check for old multi-window
mode (e.g. Samsung's multi-window mode), and #isMultiWindow() will check
for Android N multi-window.

BUG=570741
==========

to

==========
Introduce MultiWindowUtils#isLegacyMultiWindow()

MultiWindowUtils#isLecacyMultiWindow() will check for old multi-window
mode (e.g. Samsung's multi-window mode), and #isMultiWindow() will check
for Android N multi-window.

BUG=570741

Committed: https://crrev.com/16920f1d78f2f2777c16779fa6ed4d83225282c0
Cr-Commit-Position: refs/heads/master@{#371631}
==========

[commit-bot: I haz the power, 2016-01-26 23:19:43]

Patchset 2 (id:??) landed as
https://crrev.com/16920f1d78f2f2777c16779fa6ed4d83225282c0
Cr-Commit-Position: refs/heads/master@{#371631}