chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java - Issue 1633763003: Introduce MultiWindowUtils#isLegacyMultiWindow()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java

Issue 1633763003: Introduce MultiWindowUtils#isLegacyMultiWindow() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java

index 8fff2658dda3e0d17967ec28fac2f33e8f7b3fe6..3cccd6cbfd8b0ad235ac16cebd699650a3827e0d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java

@@ -48,7 +48,7 @@ public class SigninPromoScreen

// navigate to and view a URL on startup), the instance is part of the field trial,

// and the promo has been marked to display.

ChromePreferenceManager preferenceManager = ChromePreferenceManager.getInstance(activity);

- if (MultiWindowUtils.getInstance().isMultiWindow(activity)) return false;

+ if (MultiWindowUtils.getInstance().isLegacyMultiWindow(activity)) return false;

if (!preferenceManager.getShowSigninPromo()) return false;

preferenceManager.setShowSigninPromo(false);