chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java - Issue 1633763003: Introduce MultiWindowUtils#isLegacyMultiWindow()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java

Issue 1633763003: Introduce MultiWindowUtils#isLegacyMultiWindow() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java

index b2e7241ad3cd41ab3d9e95ef6e91e73ad5440bec..d833820f27e5e461d434aec0ce10a24cfc228c32 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java

@@ -52,7 +52,7 @@ public class DataReductionPromoScreen extends Dialog implements View.OnClickList

if (getDisplayedDataReductionPromo(parentActivity)) return;

// Showing the promo dialog in multiwindow mode is broken on Galaxy Note devices:

// http://crbug.com/354696. If we're in multiwindow mode, save the dialog for later.

- if (MultiWindowUtils.getInstance().isMultiWindow(parentActivity)) return;

+ if (MultiWindowUtils.getInstance().isLegacyMultiWindow(parentActivity)) return;

DataReductionPromoScreen promoScreen = new DataReductionPromoScreen(parentActivity);

promoScreen.setOnDismissListener(promoScreen);