Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3668)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java

Issue 1633763003: Introduce MultiWindowUtils#isLegacyMultiWindow() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java
index abb5eb1496651f1f81cd7323e8f9428977d7aea7..feb69ce7a487d82ae12089d4cb5ff27572c367e5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java
@@ -41,7 +41,7 @@ public class MultiWindowUtils {
/**
* @param activity The {@link Activity} to check.
- * @return Whether or not {@code activity} is currently in multi-window mode.
+ * @return Whether or not {@code activity} is currently in Android N+ multi-window mode.
*/
public boolean isMultiWindow(Activity activity) {
// This logic is overridden in a subclass.
@@ -50,12 +50,22 @@ public class MultiWindowUtils {
/**
* @param activity The {@link Activity} to check.
+ * @return Whether or not {@code activity} is currently in legacy pre-N multi-window mode
+ * (e.g. Samsung's multi-window mode).
+ */
+ public boolean isLegacyMultiWindow(Activity activity) {
+ // This logic is overridden in a subclass.
+ return false;
+ }
+
+ /**
+ * @param activity The {@link Activity} to check.
* @return Whether or not {@code activity} should run in multi-instance mode.
*/
public boolean shouldRunInMultiInstanceMode(ChromeLauncherActivity activity) {
return Build.VERSION.SDK_INT > Build.VERSION_CODES.LOLLIPOP
&& TextUtils.equals(activity.getIntent().getAction(), Intent.ACTION_MAIN)
- && isMultiWindow(activity)
+ && isLegacyMultiWindow(activity)
&& activity.isChromeBrowserActivityRunning();
}
@@ -64,7 +74,7 @@ public class MultiWindowUtils {
*/
@TargetApi(Build.VERSION_CODES.LOLLIPOP)
public void makeMultiInstanceIntent(Activity activity, Intent intent) {
- if (activity instanceof ChromeLauncherActivity && isMultiWindow(activity)) {
+ if (activity instanceof ChromeLauncherActivity && isLegacyMultiWindow(activity)) {
if (TextUtils.equals(ChromeTabbedActivity.class.getName(),
intent.getComponent().getClassName())) {
intent.setClassName(activity, MultiInstanceChromeTabbedActivity.class.getName());

Powered by Google App Engine
This is Rietveld 408576698