Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1632713002: Revert of AVX 2 SrcOver blits: color32, blitmask. (Closed)

Created:
4 years, 11 months ago by msarett
Modified:
4 years, 11 months ago
Reviewers:
herb_g, mtklein, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of AVX 2 SrcOver blits: color32, blitmask. (patchset #24 id:450001 of https://codereview.chromium.org/1532613002/ ) Reason for revert: Bot failures Original issue's description: > AVX 2 SrcOver blits: color32, blitmask. > > As a follow up to the SSE 4.1 CL, this should look pretty familiar. > > I've made some organizational changes around how we load, store, pack, and unpack data that I think makes things clearer and more orthogonal, and it'll make it easier to try out a pmaddubsw lerp. I have backported these changes to the SSE 4.1 code, and I hope that I can actually get a lot of this code templated for sharing between the two later. > > Perf changes (relative to SSE 4.1): > Xfermode_SrcOver: 1650 -> 1180 (0.71x) // large opaque blit > Xfermode_SrcOver_aa: 1794 -> 1653 (0.92x) // large opaque + small transparent > text_16_AA_{FF,BK,WT}: 1.72 -> 1.59 (0.92x) // small opaque blit > text_16_AA_88: 1.83 -> 1.77 (0.97x) // small transparent blit > > This should be a big throughout win, and a small latency win. > This should all be pixel-exact to the previous SSE 4.1 code. > > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1532613002 > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot > > Committed: https://skia.googlesource.com/skia/+/5d2117015eb271e09faf4a7ddd89093c9d618a36 TBR=herb@google.com,mtklein@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/0dfffbeeec3078f6a03e83a4efa4c45fefdd338d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -363 lines) Patch
M gyp/opts.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M gyp/opts.gypi View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkOpts.cpp View 1 chunk +1 line, -1 line 0 comments Download
D src/opts/SkOpts_avx2.cpp View 1 chunk +0 lines, -237 lines 0 comments Download
M src/opts/SkOpts_sse41.cpp View 5 chunks +84 lines, -122 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
msarett
Created Revert of AVX 2 SrcOver blits: color32, blitmask.
4 years, 11 months ago (2016-01-25 16:54:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632713002/1
4 years, 11 months ago (2016-01-25 16:54:43 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 16:54:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0dfffbeeec3078f6a03e83a4efa4c45fefdd338d

Powered by Google App Engine
This is Rietveld 408576698