Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 1628133002: [turbofan] Add RoundUint32ToFloat32 operator to Turbofan. (Closed)

Created:
4 years, 11 months ago by Jing
Modified:
4 years, 10 months ago
Reviewers:
titzer, ahaas, v8-arm-ports
CC:
v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add RoundUint32ToFloat32 operator to Turbofan. BUG= Committed: https://crrev.com/187b3f2845a39f428ac46d72450373c678d011de Cr-Commit-Position: refs/heads/master@{#33796}

Patch Set 1 #

Patch Set 2 : add arm/arm64 implementation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -3 lines) Patch
M src/arm/assembler-arm.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm/instruction-scheduler-arm.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-scheduler-arm64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ia32/instruction-scheduler-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/instruction-scheduler-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Jing
4 years, 10 months ago (2016-02-04 02:31:08 UTC) #2
Jing
4 years, 10 months ago (2016-02-04 07:35:21 UTC) #5
ahaas
On 2016/02/04 at 07:35:21, jing.bao wrote: > Did you check that the disassembler works for ...
4 years, 10 months ago (2016-02-04 09:12:40 UTC) #6
ahaas
lgtm
4 years, 10 months ago (2016-02-04 09:12:54 UTC) #7
titzer
On 2016/02/04 09:12:54, ahaas wrote: > lgtm lgtm
4 years, 10 months ago (2016-02-04 09:16:20 UTC) #8
Jing
On 2016/02/04 09:12:40, ahaas wrote: > On 2016/02/04 at 07:35:21, jing.bao wrote: > > > ...
4 years, 10 months ago (2016-02-05 02:11:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1628133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1628133002/20001
4 years, 10 months ago (2016-02-06 01:35:27 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-06 18:07:43 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-06 18:08:19 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/187b3f2845a39f428ac46d72450373c678d011de
Cr-Commit-Position: refs/heads/master@{#33796}

Powered by Google App Engine
This is Rietveld 408576698