Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 16256018: Update content/ to use WeakPtr<T>::get() instead of implicit "operator T*" (Closed)

Created:
7 years, 6 months ago by akalin
Modified:
7 years, 6 months ago
Reviewers:
Avi (use Gerrit), jam
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, sail+watch_chromium.org, Ryan Sleevi, darin (slow to review)
Visibility:
Public.

Description

Update content/ to use WeakPtr<T>::get() instead of implicit "operator T*" BUG=245942 R=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203775

Patch Set 1 #

Patch Set 2 : Fix incorrectly modified code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -81 lines) Patch
M content/browser/browser_plugin/browser_plugin_embedder.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_request_handle.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/shader_disk_cache.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/plugin_loader_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/web_contents_video_capture_device.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/ssl/ssl_error_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/ssl/ssl_manager.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M content/browser/tracing/tracing_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/render_view_host_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/image_transport_surface.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/webplugin_delegate_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/broker_process_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_bindings.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/input_handler_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_dispatcher.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M content/renderer/media/renderer_gpu_video_decoder_factories.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M content/renderer/pepper/pepper_broker_impl.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/pepper/pepper_file_chooser_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_platform_audio_input_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_platform_video_capture_impl.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_video_source_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
akalin
+jam for OWNERS review +rsleevi FYI (see diff between patch 1 and 2) Might end ...
7 years, 6 months ago (2013-06-03 19:35:46 UTC) #1
jam
redirecting to Avi, thanks
7 years, 6 months ago (2013-06-03 20:26:35 UTC) #2
jam
btw you should get Darin's ok on this overall change first, since he wrote WeakPtr ...
7 years, 6 months ago (2013-06-03 20:28:42 UTC) #3
akalin
On 2013/06/03 20:28:42, jam wrote: > btw you should get Darin's ok on this overall ...
7 years, 6 months ago (2013-06-03 20:50:18 UTC) #4
Avi (use Gerrit)
lgtm
7 years, 6 months ago (2013-06-03 21:17:57 UTC) #5
akalin
7 years, 6 months ago (2013-06-03 21:25:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r203775 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698