content/renderer/pepper/pepper_platform_audio_input_impl.cc - Issue 16256018: Update content/ to use WeakPtr<T>::get() instead of implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_platform_audio_input_impl.cc

Issue 16256018: Update content/ to use WeakPtr<T>::get() instead of implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix incorrectly modified code Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/pepper/pepper_file_chooser_host.cc ('k') | content/renderer/pepper/pepper_platform_video_capture_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/pepper_platform_audio_input_impl.cc

diff --git a/content/renderer/pepper/pepper_platform_audio_input_impl.cc b/content/renderer/pepper/pepper_platform_audio_input_impl.cc

index 7ec5dc532b2940f88b11e444a4a82c46a157ff03..87afb09a7b158f08d1485cb576bccc85a93ec3a3 100644

--- a/content/renderer/pepper/pepper_platform_audio_input_impl.cc

+++ b/content/renderer/pepper/pepper_platform_audio_input_impl.cc

@@ -136,7 +136,7 @@ bool PepperPlatformAudioInputImpl::Initialize(

webkit::ppapi::PluginDelegate::PlatformAudioInputClient* client) {

DCHECK(main_message_loop_proxy_->BelongsToCurrentThread());

- if (!plugin_delegate || !client)

+ if (!plugin_delegate.get() || !client)

return false;

ipc_ = RenderThreadImpl::current()->audio_input_message_filter()->

@@ -208,7 +208,7 @@ void PepperPlatformAudioInputImpl::OnDeviceOpened(int request_id,

const std::string& label) {

DCHECK(main_message_loop_proxy_->BelongsToCurrentThread());

- if (succeeded && plugin_delegate_) {

+ if (succeeded && plugin_delegate_.get()) {

DCHECK(!label.empty());

label_ = label;

@@ -231,7 +231,7 @@ void PepperPlatformAudioInputImpl::OnDeviceOpened(int request_id,

void PepperPlatformAudioInputImpl::CloseDevice() {

DCHECK(main_message_loop_proxy_->BelongsToCurrentThread());

- if (plugin_delegate_ && !label_.empty()) {

+ if (plugin_delegate_.get() && !label_.empty()) {

plugin_delegate_->CloseDevice(label_);

label_.clear();

}