content/renderer/pepper/pepper_file_chooser_host.cc - Issue 16256018: Update content/ to use WeakPtr<T>::get() instead of implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_file_chooser_host.cc

Issue 16256018: Update content/ to use WeakPtr<T>::get() instead of implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix incorrectly modified code Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/pepper/pepper_file_chooser_host.cc

diff --git a/content/renderer/pepper/pepper_file_chooser_host.cc b/content/renderer/pepper/pepper_file_chooser_host.cc

index d34ce8861bf6f33a854ad096435f5aa610921690..b63ebf92b5b994eea4ac9bd73fdcdf0316ea9a63 100644

--- a/content/renderer/pepper/pepper_file_chooser_host.cc

+++ b/content/renderer/pepper/pepper_file_chooser_host.cc

@@ -33,7 +33,7 @@ class PepperFileChooserHost::CompletionHandler

virtual void didChooseFile(

const WebKit::WebVector<WebKit::WebString>& file_names) {

- if (host_) {

+ if (host_.get()) {

std::vector<PepperFileChooserHost::ChosenFileInfo> files;

for (size_t i = 0; i < file_names.size(); i++) {

files.push_back(PepperFileChooserHost::ChosenFileInfo(

@@ -47,7 +47,7 @@ class PepperFileChooserHost::CompletionHandler

}