Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1623433004: Add missing vcvt instructions to integrated ARM assembler. (Closed)

Created:
4 years, 11 months ago by Karl
Modified:
4 years, 11 months ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix nits. #

Total comments: 2

Patch Set 3 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -94 lines) Patch
M src/DartARM32/assembler_arm.h View 1 1 chunk +9 lines, -4 lines 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 chunk +21 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 2 chunks +104 lines, -2 lines 0 comments Download
M src/IceInstARM32.cpp View 1 chunk +22 lines, -6 lines 0 comments Download
A + tests_lit/assembler/arm32/vcvt.f32.s32.ll View 1 2 chunks +11 lines, -11 lines 0 comments Download
A + tests_lit/assembler/arm32/vcvt.f32.u32.ll View 1 2 2 chunks +11 lines, -11 lines 0 comments Download
A + tests_lit/assembler/arm32/vcvt.f64.s32.ll View 2 chunks +11 lines, -11 lines 0 comments Download
A + tests_lit/assembler/arm32/vcvt.f64.u32.ll View 2 chunks +11 lines, -11 lines 0 comments Download
A + tests_lit/assembler/arm32/vcvt.s32.f64.ll View 2 chunks +10 lines, -10 lines 0 comments Download
A + tests_lit/assembler/arm32/vcvt.u32.f32.ll View 2 chunks +10 lines, -11 lines 0 comments Download
A + tests_lit/assembler/arm32/vcvt.u32.f64.ll View 2 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Karl
4 years, 11 months ago (2016-01-22 22:13:51 UTC) #3
Jim Stichnoth
lgtm https://codereview.chromium.org/1623433004/diff/20001/tests_lit/assembler/arm32/vcvt.f32.u32.ll File tests_lit/assembler/arm32/vcvt.f32.u32.ll (right): https://codereview.chromium.org/1623433004/diff/20001/tests_lit/assembler/arm32/vcvt.f32.u32.ll#newcode1 tests_lit/assembler/arm32/vcvt.f32.u32.ll:1: ; Show that we know how to translate ...
4 years, 11 months ago (2016-01-22 22:50:06 UTC) #4
Karl
Committed patchset #3 (id:40001) manually as ab389f2285132ad8f4ad12cdf1e44f3ac5aa0403 (presubmit successful).
4 years, 11 months ago (2016-01-22 23:08:48 UTC) #6
Karl
4 years, 11 months ago (2016-01-22 23:47:48 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1623433004/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/vcvt.f32.u32.ll (right):

https://codereview.chromium.org/1623433004/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/vcvt.f32.u32.ll:1: ; Show that we know how to
translate converting unsigned integer to floast.
On 2016/01/22 22:50:06, stichnot wrote:
> float

Done.

Powered by Google App Engine
This is Rietveld 408576698