DevTools: make InjectedScript heap-allocated.

DevTools: make InjectedScript heap-allocated.

BUG=580337
Committed: https://crrev.com/d54c4689d9ef1d3a6844c695d473304b6ca4080f
Cr-Commit-Position: refs/heads/master@{#371436}

[pfeldman, 2016-01-24 07:34:19]

https://codereview.chromium.org/1622213002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp (right):

https://codereview.chromium.org/1622213002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp:195:
jsonObj->setExecutionContextId(scriptState->contextIdInDebugger());
This is a change to the semantics - injected script is no longer created here.

https://codereview.chromium.org/1622213002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp (right):

https://codereview.chromium.org/1622213002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp:93: int
executionContextId = optExecutionContextId ? *optExecutionContextId :
defaultScriptState()->contextIdInDebugger();
This is a change to semantics - injected script is no longer created here. I
rely upon execution context being reported by now.

[pfeldman, 2016-01-24 07:34:46]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[sof, 2016-01-24 08:05:32]

https://codereview.chromium.org/1622213002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InjectedScript.h (left):

https://codereview.chromium.org/1622213002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InjectedScript.h:53: DISALLOW_NEW();
USING_FAST_MALLOC(InjectedScript); ?

[dgozman, 2016-01-25 18:28:17]

lgtm

https://codereview.chromium.org/1622213002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/ScriptState.h (right):

https://codereview.chromium.org/1622213002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/ScriptState.h:92: int
contextIdInDebugger();
Let's comment this may only be called when contextIsValid() is true.

[pfeldman, 2016-01-25 18:56:19]

On 2016/01/25 18:28:17, dgozman wrote:
> lgtm
> 
>
https://codereview.chromium.org/1622213002/diff/1/third_party/WebKit/Source/b...
> File third_party/WebKit/Source/bindings/core/v8/ScriptState.h (right):
> 
>
https://codereview.chromium.org/1622213002/diff/1/third_party/WebKit/Source/b...
> third_party/WebKit/Source/bindings/core/v8/ScriptState.h:92: int
> contextIdInDebugger();
> Let's comment this may only be called when contextIsValid() is true.

It'll crash otherwise! :)

[pfeldman, 2016-01-25 18:56:25]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-01-25 18:57:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1622213002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1622213002/1

[sof, 2016-01-25 18:59:11]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2016-01-25 18:59:12]

https://codereview.chromium.org/1622213002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InjectedScript.h (left):

https://codereview.chromium.org/1622213002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InjectedScript.h:53: DISALLOW_NEW();
On 2016/01/24 08:05:32, sof wrote:
> USING_FAST_MALLOC(InjectedScript); ?

Not following up on this one?

[pfeldman, 2016-01-25 18:59:47]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2016-01-25 19:00:11]

On 2016/01/25 18:59:12, sof wrote:
>
https://codereview.chromium.org/1622213002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/inspector/InjectedScript.h (left):
> 
>
https://codereview.chromium.org/1622213002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/inspector/InjectedScript.h:53: DISALLOW_NEW();
> On 2016/01/24 08:05:32, sof wrote:
> > USING_FAST_MALLOC(InjectedScript); ?
> 
> Not following up on this one?

Ouch, sorry, sure I am.

[pfeldman, 2016-01-25 19:02:41]

https://codereview.chromium.org/1622213002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InjectedScript.h (left):

https://codereview.chromium.org/1622213002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InjectedScript.h:53: DISALLOW_NEW();
I absolutely have to! Why allocating this rare object slowly when there is a way
to speed things up!

[pfeldman, 2016-01-25 19:03:37]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-01-25 19:03:38]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1622213002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-01-25 19:06:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1622213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1622213002/20001

[commit-bot: I haz the power, 2016-01-25 19:26:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 19:26:01]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[pfeldman, 2016-01-25 20:23:27]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-01-25 20:23:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1622213002/#ps40001
(title: "assertion fixed")

[commit-bot: I haz the power, 2016-01-25 20:27:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1622213002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1622213002/40001

[commit-bot: I haz the power, 2016-01-25 21:43:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 21:43:31]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2016-01-26 01:30:14]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-01-26 01:30:15]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1622213002/#ps60001
(title: "fixed protocol tests.")

[commit-bot: I haz the power, 2016-01-26 01:33:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1622213002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1622213002/60001

[commit-bot: I haz the power, 2016-01-26 03:12:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-26 03:13:46]

Description was changed from

==========
DevTools: make InjectedScript heap-allocated.

BUG=580337
==========

to

==========
DevTools: make InjectedScript heap-allocated.

BUG=580337

Committed: https://crrev.com/d54c4689d9ef1d3a6844c695d473304b6ca4080f
Cr-Commit-Position: refs/heads/master@{#371436}
==========

[commit-bot: I haz the power, 2016-01-26 03:13:47]

Patchset 4 (id:??) landed as
https://crrev.com/d54c4689d9ef1d3a6844c695d473304b6ca4080f
Cr-Commit-Position: refs/heads/master@{#371436}