DevTools: make InjectedScript heap-allocated.

third_party/WebKit/Source/core/inspector/InjectedScript.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 30 matching lines @@
 
 namespace blink {
 
 class JSONValue;
 class RemoteObjectId;
 class ScriptFunctionCall;
 
 typedef String ErrorString;
 PassRefPtr<JSONValue> toJSONValue(const ScriptValue&);
 
-
 class InjectedScript final {
-    DISALLOW_NEW();

[sof, 2016/01/24 08:05:32]

USING_FAST_MALLOC(InjectedScript); ?

[sof, 2016/01/25 18:59:12]

Not following up on this one?

[pfeldman, 2016/01/25 19:02:41]

I absolutely have to! Why allocating this rare object slowly when there is a way
to speed things up!

 public:
     InjectedScript();
     ~InjectedScript();
 
-    bool isEmpty() const { return m_injectedScriptObject.isEmpty(); }
     ScriptState* scriptState() const
     {
         ASSERT(!isEmpty());
         return m_injectedScriptObject.scriptState();
     }
 
     void evaluate(
         ErrorString*,
         const String& expression,
         const String& objectGroup,
@@ skipping 41 matching lines @@
     PassRefPtr<TypeBuilder::Runtime::RemoteObject> wrapTable(const ScriptValue& table, const ScriptValue& columns) const;
     v8::Local<v8::Value> findObject(const RemoteObjectId&) const;
 
     String objectIdToObjectGroupName(const String& objectId) const;
     void releaseObjectGroup(const String&);
 
     void setCustomObjectFormatterEnabled(bool);
     int contextId() { return m_contextId; }
 
 private:
-    friend InjectedScript InjectedScriptManager::injectedScriptFor(ScriptState*);
+    friend InjectedScript* InjectedScriptManager::injectedScriptFor(ScriptState*);
     using InspectedStateAccessCheck = bool (*)(ScriptState*);
     InjectedScript(ScriptValue, InspectedStateAccessCheck, PassRefPtr<InjectedScriptNative>, int contextId);
 
     void initialize(ScriptValue, InspectedStateAccessCheck);
     bool canAccessInspectedWindow() const;
     const ScriptValue& injectedScriptObject() const;
     ScriptValue callFunctionWithEvalEnabled(ScriptFunctionCall&, bool& hadException) const;
     void makeCall(ScriptFunctionCall&, RefPtr<JSONValue>* result);
     void makeEvalCall(ErrorString*, ScriptFunctionCall&, RefPtr<TypeBuilder::Runtime::RemoteObject>* result, TypeBuilder::OptOutput<bool>* wasThrown, RefPtr<TypeBuilder::Debugger::ExceptionDetails>* = 0);
     void makeCallWithExceptionDetails(ScriptFunctionCall&, RefPtr<JSONValue>* result, RefPtr<TypeBuilder::Debugger::ExceptionDetails>*);
 
     ScriptValue m_injectedScriptObject;
     InspectedStateAccessCheck m_inspectedStateAccessCheck;
     RefPtr<InjectedScriptNative> m_native;
     int m_contextId;
 };
 
 } // namespace blink
 
 #endif