third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp - Issue 1622213002: DevTools: make InjectedScript heap-allocated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

Issue 1622213002: DevTools: make InjectedScript heap-allocated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed protocol tests. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InjectedScriptManager.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

index 0b39ac1c57fce5ad781850b562cf0cfbb2145fd4..4319bf68882e4635e79af2d547e36f88e9359a33 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

@@ -389,15 +389,15 @@ void InspectorAnimationAgent::resolveAnimation(ErrorString* errorString, const S

ScriptState* scriptState = ScriptState::forMainWorld(frame);

if (!scriptState)

return;

- InjectedScript injectedScript = m_injectedScriptManager->injectedScriptFor(scriptState);

- if (injectedScript.isEmpty())

+ InjectedScript* injectedScript = m_injectedScriptManager->injectedScriptFor(scriptState);

+ if (!injectedScript)

return;

ScriptState::Scope scope(scriptState);

v8::Isolate* isolate = scriptState->isolate();

ScriptValue scriptValue = ScriptValue(scriptState, toV8(animation, scriptState->context()->Global(), isolate));

- injectedScript.releaseObjectGroup("animation");

- result = injectedScript.wrapObject(scriptValue, "animation");

+ injectedScript->releaseObjectGroup("animation");

+ result = injectedScript->wrapObject(scriptValue, "animation");

}

static CSSPropertyID animationProperties[] = {