Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1618843002: Hide SkCanvas::{set,get}DrawFilter (Closed)

Created:
4 years, 11 months ago by f(malita)
Modified:
4 years, 11 months ago
Reviewers:
djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkCanvas.h View 2 chunks +9 lines, -1 line 2 comments Download
M include/utils/SkNWayCanvas.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 3 chunks +6 lines, -0 lines 0 comments Download
M src/utils/SkCanvasStateUtils.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
f(malita)
4 years, 11 months ago (2016-01-21 15:48:53 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618843002/1
4 years, 11 months ago (2016-01-21 15:49:03 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-21 15:56:56 UTC) #6
djsollen
https://codereview.chromium.org/1618843002/diff/1/include/core/SkCanvas.h File include/core/SkCanvas.h (right): https://codereview.chromium.org/1618843002/diff/1/include/core/SkCanvas.h#newcode1152 include/core/SkCanvas.h:1152: #ifdef SK_INTERNAL why do we need SK_INTERNAL?
4 years, 11 months ago (2016-01-21 16:34:28 UTC) #7
f(malita)
https://codereview.chromium.org/1618843002/diff/1/include/core/SkCanvas.h File include/core/SkCanvas.h (right): https://codereview.chromium.org/1618843002/diff/1/include/core/SkCanvas.h#newcode1152 include/core/SkCanvas.h:1152: #ifdef SK_INTERNAL On 2016/01/21 16:34:27, djsollen wrote: > why ...
4 years, 11 months ago (2016-01-21 17:54:16 UTC) #8
reed1
lgtm
4 years, 11 months ago (2016-01-21 18:39:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618843002/1
4 years, 11 months ago (2016-01-22 02:46:36 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 02:47:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7765000709dc64eb23be7df47d1f995d1f787115

Powered by Google App Engine
This is Rietveld 408576698