Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: include/core/SkCanvas.h

Issue 1618843002: Hide SkCanvas::{set,get}DrawFilter (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/skia_for_android_framework_defines.gypi ('k') | include/utils/SkNWayCanvas.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkCanvas.h
diff --git a/include/core/SkCanvas.h b/include/core/SkCanvas.h
index d1de626315ee52503517eb84c83e4de231130b64..66741519bf8aa1058f66e7a82d95d8e6309a91db 100644
--- a/include/core/SkCanvas.h
+++ b/include/core/SkCanvas.h
@@ -1149,11 +1149,18 @@ public:
void drawDrawable(SkDrawable*, SkScalar x, SkScalar y);
//////////////////////////////////////////////////////////////////////////
+#ifdef SK_INTERNAL
djsollen 2016/01/21 16:34:27 why do we need SK_INTERNAL?
f(malita) 2016/01/21 17:54:16 The intent is to only hide this for external users
+#ifndef SK_SUPPORT_LEGACY_DRAWFLTER
+ #define SK_SUPPORT_LEGACY_DRAWFLTER
+#endif
+#endif
+#ifdef SK_SUPPORT_LEGACY_DRAWFLTER
/** Get the current filter object. The filter's reference count is not
affected. The filter is saved/restored, just like the matrix and clip.
@return the canvas' filter (or NULL).
*/
+ SK_ATTR_EXTERNALLY_DEPRECATED("getDrawFilter use is deprecated")
SkDrawFilter* getDrawFilter() const;
/** Set the new filter (or NULL). Pass NULL to clear any existing filter.
@@ -1164,8 +1171,9 @@ public:
@param filter the new filter (or NULL)
@return the new filter
*/
+ SK_ATTR_EXTERNALLY_DEPRECATED("setDrawFilter use is deprecated")
virtual SkDrawFilter* setDrawFilter(SkDrawFilter* filter);
-
+#endif
//////////////////////////////////////////////////////////////////////////
/**
« no previous file with comments | « gyp/skia_for_android_framework_defines.gypi ('k') | include/utils/SkNWayCanvas.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698