Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1616073006: Remove cached Activity from TabWebContentsDelegate and ContextMenuPopulator (Closed)

Created:
4 years, 11 months ago by Yusuf
Modified:
4 years, 11 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove cached Activityfrom TabWebContentsDelegate and ContextMenuPopulator Use the added getActivity and getTabModelSelector for getting access to WindowAndroid's copy and don't cache Activity inside tab related classes. BUG=546736 Committed: https://crrev.com/a670cc9196acabf5d1e3449dcd633b5778111e24 Cr-Commit-Position: refs/heads/master@{#371090}

Patch Set 1 #

Patch Set 2 : Fixed findbugs #

Messages

Total messages: 16 (8 generated)
Yusuf
4 years, 11 months ago (2016-01-22 20:59:33 UTC) #3
gone
lgtm
4 years, 11 months ago (2016-01-22 21:11:57 UTC) #4
gone
lgtm lgtm
4 years, 11 months ago (2016-01-22 21:11:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616073006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616073006/1
4 years, 11 months ago (2016-01-22 21:12:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/11965)
4 years, 11 months ago (2016-01-22 22:37:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616073006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616073006/20001
4 years, 11 months ago (2016-01-22 22:51:21 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-23 00:05:37 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-23 00:07:32 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a670cc9196acabf5d1e3449dcd633b5778111e24
Cr-Commit-Position: refs/heads/master@{#371090}

Powered by Google App Engine
This is Rietveld 408576698