chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTabDelegateFactory.java - Issue 1616073006: Remove cached Activity from TabWebContentsDelegate and ContextMenuPopulator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTabDelegateFactory.java

Issue 1616073006: Remove cached Activity from TabWebContentsDelegate and ContextMenuPopulator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed findbugs Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTabDelegateFactory.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTabDelegateFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTabDelegateFactory.java

index 7a9907b41b98c05919e7e46c8f25ed0c4e31af68..6d7f3df72f8ce5a8a55035fa443460074bdadf60 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTabDelegateFactory.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTabDelegateFactory.java

@@ -4,7 +4,6 @@

package org.chromium.chrome.browser.document;

-import org.chromium.chrome.browser.ChromeActivity;

import org.chromium.chrome.browser.ChromeApplication;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.tab.TabDelegateFactory;

@@ -23,8 +22,8 @@ public class DocumentTabDelegateFactory extends TabDelegateFactory {

extends TabWebContentsDelegateAndroid {

private boolean mIsIncognito;

- public DocumentTabWebContentsDelegateAndroid(Tab tab, ChromeActivity activity) {

- super(tab, activity);

+ public DocumentTabWebContentsDelegateAndroid(Tab tab) {

+ super(tab);

mIsIncognito = tab.isIncognito();

}

@@ -39,8 +38,7 @@ public class DocumentTabDelegateFactory extends TabDelegateFactory {

}

@Override

- public TabWebContentsDelegateAndroid createWebContentsDelegate(

- Tab tab, ChromeActivity activity) {

- return new DocumentTabWebContentsDelegateAndroid(tab, activity);

+ public TabWebContentsDelegateAndroid createWebContentsDelegate(Tab tab) {

+ return new DocumentTabWebContentsDelegateAndroid(tab);

}