chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java - Issue 1616073006: Remove cached Activity from TabWebContentsDelegate and ContextMenuPopulator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 1616073006: Remove cached Activity from TabWebContentsDelegate and ContextMenuPopulator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed findbugs Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTabDelegateFactory.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

index 76668f97c56273782b195cb723baec8ef7ffd2a4..f48cd887e4e64a3a4a2dbf6bec58a6ec74c0e18c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

@@ -1568,7 +1568,7 @@ public final class Tab implements ViewGroup.OnHierarchyChangeListener,

new FrameLayout.LayoutParams(

LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT));

- mWebContentsDelegate = mDelegateFactory.createWebContentsDelegate(this, getActivity());

+ mWebContentsDelegate = mDelegateFactory.createWebContentsDelegate(this);

mWebContentsObserver =

new TabWebContentsObserver(mContentViewCore.getWebContents(), this);

@@ -1579,8 +1579,8 @@ public final class Tab implements ViewGroup.OnHierarchyChangeListener,

assert mNativeTabAndroid != 0;

nativeInitWebContents(

mNativeTabAndroid, mIncognito, mContentViewCore, mWebContentsDelegate,

- new TabContextMenuPopulator(mDelegateFactory.createContextMenuPopulator(

- this, getActivity()), this));

+ new TabContextMenuPopulator(mDelegateFactory.createContextMenuPopulator(this),

+ this));

// In the case where restoring a Tab or showing a prerendered one we already have a

// valid infobar container, no need to recreate one.