Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java

Issue 1616073006: Remove cached Activity from TabWebContentsDelegate and ContextMenuPopulator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed findbugs Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTabDelegateFactory.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java
index 6ca6eeedf38d547a3fcdf629c36e6356cc2e9cf6..459c7575a042d420d9375cd0165a70d493667e8d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java
@@ -117,8 +117,8 @@ public class CustomTabDelegateFactory extends TabDelegateFactory {
/**
* See {@link TabWebContentsDelegateAndroid}.
*/
- public CustomTabWebContentsDelegate(Tab tab, CustomTabActivity activity) {
- super(tab, activity);
+ public CustomTabWebContentsDelegate(Tab tab) {
+ super(tab);
}
@Override
@@ -136,10 +136,8 @@ public class CustomTabDelegateFactory extends TabDelegateFactory {
private ExternalNavigationHandler mNavigationHandler;
@Override
- public TabWebContentsDelegateAndroid createWebContentsDelegate(Tab tab,
- ChromeActivity activity) {
- assert activity instanceof CustomTabActivity;
- return new CustomTabWebContentsDelegate(tab, (CustomTabActivity) activity);
+ public TabWebContentsDelegateAndroid createWebContentsDelegate(Tab tab) {
+ return new CustomTabWebContentsDelegate(tab);
}
@Override
@@ -151,9 +149,8 @@ public class CustomTabDelegateFactory extends TabDelegateFactory {
}
@Override
- public ContextMenuPopulator createContextMenuPopulator(Tab tab, ChromeActivity activity) {
- return new ChromeContextMenuPopulator(
- new TabContextMenuItemDelegate(tab, activity),
+ public ContextMenuPopulator createContextMenuPopulator(Tab tab) {
+ return new ChromeContextMenuPopulator(new TabContextMenuItemDelegate(tab),
ChromeContextMenuPopulator.CUSTOM_TAB_MODE);
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTabDelegateFactory.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698