Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1615253006: Removed last references to old sync points. (Closed)

Created:
4 years, 11 months ago by David Yen
Modified:
4 years, 11 months ago
Reviewers:
sky, piman
CC:
chromium-reviews, rjkroege, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, abarth-chromium, ben+mojo_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed last references to old sync points. BUG=514815, 373452 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7246e45b7da6c14b1384658481ec49b45b5b488c Cr-Commit-Position: refs/heads/master@{#371082}

Patch Set 1 #

Patch Set 2 : Removed references in TestContextSupport #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -411 lines) Patch
M cc/test/test_context_support.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M cc/test/test_context_support.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M components/mus/gles2/command_buffer_driver.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/gles2/command_buffer_driver.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M components/mus/gles2/command_buffer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/gles2/command_buffer_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/mus/gles2/command_buffer_local.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/mus/gles2/command_buffer_local.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M gpu/command_buffer/client/client_test_helper.h View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/context_support.h View 2 chunks +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 2 chunks +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M gpu/command_buffer/client/gpu_control.h View 1 chunk +0 lines, -17 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 2 chunks +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M gpu/command_buffer/service/sync_point_manager.h View 2 chunks +0 lines, -25 lines 0 comments Download
M gpu/command_buffer/service/sync_point_manager.cc View 3 chunks +1 line, -64 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.h View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.h View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M mojo/gles2/gles2_impl.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M mojo/public/c/gles2/gles2.h View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/public/c/gles2/gles2_types.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/platform/native/gles2_thunks.h View 2 chunks +0 lines, -6 lines 0 comments Download
M mojo/public/platform/native/gles2_thunks.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.cc View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
David Yen
Hurray, the very last sync point CL. This deletion is all trivial functions which are ...
4 years, 11 months ago (2016-01-22 21:16:27 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615253006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615253006/1
4 years, 11 months ago (2016-01-22 21:17:35 UTC) #5
piman
LGTM \o/
4 years, 11 months ago (2016-01-22 21:27:50 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/170263) mac_chromium_rel_ng on ...
4 years, 11 months ago (2016-01-22 21:31:42 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615253006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615253006/20001
4 years, 11 months ago (2016-01-22 21:45:54 UTC) #10
sky
LGTM
4 years, 11 months ago (2016-01-22 22:21:56 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-22 23:20:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615253006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615253006/20001
4 years, 11 months ago (2016-01-22 23:23:47 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-22 23:38:42 UTC) #17
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 23:40:36 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7246e45b7da6c14b1384658481ec49b45b5b488c
Cr-Commit-Position: refs/heads/master@{#371082}

Powered by Google App Engine
This is Rietveld 408576698