Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: gpu/command_buffer/service/sync_point_manager.h

Issue 1615253006: Removed last references to old sync points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed references in TestContextSupport Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/sync_point_manager.h
diff --git a/gpu/command_buffer/service/sync_point_manager.h b/gpu/command_buffer/service/sync_point_manager.h
index 13e848ffb184afee4c6ff7b94f97cd3491ec4d16..8c39441e3e1dd49d06e134c917fb8f1b48bf0048 100644
--- a/gpu/command_buffer/service/sync_point_manager.h
+++ b/gpu/command_buffer/service/sync_point_manager.h
@@ -284,31 +284,12 @@ class GPU_EXPORT SyncPointManager {
scoped_refptr<SyncPointClientState> GetSyncPointClientState(
CommandBufferNamespace namespace_id, uint64_t client_id);
- // Generates a sync point, returning its ID. This can me called on any thread.
- // IDs start at a random number. Never return 0.
- uint32_t GenerateSyncPoint();
-
- // Retires a sync point. This will call all the registered callbacks for this
- // sync point. This can only be called on the main thread.
- void RetireSyncPoint(uint32_t sync_point);
-
- // Adds a callback to the sync point. The callback will be called when the
- // sync point is retired, or immediately (from within that function) if the
- // sync point was already retired (or not created yet). This can only be
- // called on the main thread.
- void AddSyncPointCallback(uint32_t sync_point, const base::Closure& callback);
-
- bool IsSyncPointRetired(uint32_t sync_point);
-
private:
friend class SyncPointClient;
friend class SyncPointOrderData;
- typedef std::vector<base::Closure> ClosureList;
- typedef base::hash_map<uint32_t, ClosureList> SyncPointMap;
typedef base::hash_map<uint64_t, SyncPointClient*> ClientMap;
- bool IsSyncPointRetiredLocked(uint32_t sync_point);
uint32_t GenerateOrderNumber();
void DestroySyncPointClient(CommandBufferNamespace namespace_id,
uint64_t client_id);
@@ -320,12 +301,6 @@ class GPU_EXPORT SyncPointManager {
base::Lock client_maps_lock_;
ClientMap client_maps_[NUM_COMMAND_BUFFER_NAMESPACES];
- // Protects the 2 fields below. Note: callbacks shouldn't be called with this
- // held.
- base::Lock lock_;
- SyncPointMap sync_point_map_;
- uint32_t next_sync_point_;
-
DISALLOW_COPY_AND_ASSIGN(SyncPointManager);
};
« no previous file with comments | « gpu/command_buffer/service/in_process_command_buffer.cc ('k') | gpu/command_buffer/service/sync_point_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698