Implement simple name and qualified name.

Implement simple name and qualified name.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23225

[kasperl, 2013-05-27 12:15:33]

LGTM!

https://codereview.chromium.org/16097002/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart
(right):

https://codereview.chromium.org/16097002/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart:91: new
_MethodMirror(symbol, JS('', r'$[#]', name), parameterCount);
Create helpers for reading and writing to fields of $?

https://codereview.chromium.org/16097002/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart:460: if
(owner == null || _n(owner.qualifiedName) == '') return simpleName;
Consider using ? :.

https://codereview.chromium.org/16097002/diff/1/dart/tests/lib/mirrors/mirror...
File dart/tests/lib/mirrors/mirrors_test.dart (right):

https://codereview.chromium.org/16097002/diff/1/dart/tests/lib/mirrors/mirror...
dart/tests/lib/mirrors/mirrors_test.dart:220: if (isDart2js) return; //
TODO(ahe): Remove this line.
Almost there.

[ahe, 2013-05-27 13:55:55]

Thank you, Kasper!

https://codereview.chromium.org/16097002/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart
(right):

https://codereview.chromium.org/16097002/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart:91: new
_MethodMirror(symbol, JS('', r'$[#]', name), parameterCount);
On 2013/05/27 12:15:33, kasperl wrote:
> Create helpers for reading and writing to fields of $?

Added TODO (a big cleanup).

https://codereview.chromium.org/16097002/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart:460: if
(owner == null || _n(owner.qualifiedName) == '') return simpleName;
On 2013/05/27 12:15:33, kasperl wrote:
> Consider using ? :.

Did something else :-)

[ahe, 2013-05-27 13:58:20]

Committed patchset #2 manually as r23225 (presubmit successful).