Implement simple name and qualified name.

dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Patch library for dart:mirrors.
 
 import 'dart:_foreign_helper' show JS;
 import 'dart:_collection-dev' as _symbol_dev;
 import 'dart:_js_helper' show createInvocationMirror;
 import 'dart:_interceptors' show Interceptor;
@@ skipping 20 matching lines @@
   static Map<String, List<LibraryMirror>> computeLibrariesByName() {
     var result = new Map<String, List<LibraryMirror>>();
     var jsLibraries = JS('=List|Null', 'init.libraries');
     if (jsLibraries == null) return result;
     for (List data in jsLibraries) {
       String name = data[0];
       Uri uri = Uri.parse(data[1]);
       List<String> classes = data[2];
       List<String> functions = data[3];
       var libraries = result.putIfAbsent(name, () => <LibraryMirror>[]);
-      libraries.add(new _LibraryMirror(name, uri, classes, functions));
+      libraries.add(new _LibraryMirror(_s(name), uri, classes, functions));
     }
     return result;
   }
 }
 
 class _TypeMirror implements TypeMirror {
   final Symbol simpleName;
   _TypeMirror(this.simpleName);
 }
 
 class _LibraryMirror extends _ObjectMirror implements LibraryMirror {
-  final String _name;
+  final Symbol simpleName;
   final Uri uri;
   final List<String> _classes;
   final List<String> _functions;
 
-  _LibraryMirror(this._name, this.uri, this._classes, this._functions);
+  _LibraryMirror(this.simpleName, this.uri, this._classes, this._functions);
+
+  Symbol get qualifiedName => simpleName;
 
   Map<Symbol, ClassMirror> get classes {
     var result = new Map<Symbol, ClassMirror>();
     for (int i = 0; i < _classes.length; i += 2) {
       Symbol symbol = _s(_classes[i]);
       _ClassMirror cls = _reflectClass(symbol, _classes[i + 1]);
       result[symbol] = cls;
       cls._owner = this;
     }
     return result;
   }
 
   InstanceMirror setField(Symbol fieldName, Object arg) {
     // TODO(ahe): This is extremely dangerous!!!
     JS('void', r'$[#] = #', _n(fieldName), arg);
     return _reflect(arg);
   }
 
   InstanceMirror getField(Symbol fieldName) {
     // TODO(ahe): This is extremely dangerous!!!
     return _reflect(JS('', r'$[#]', _n(fieldName)));
   }
+
+  Map<Symbol, MethodMirror> get functions {
+    var result = new Map<Symbol, MethodMirror>();
+    for (int i = 0; i < _functions.length; i++) {
+      String name = _functions[i];
+      Symbol symbol = _s(name);
+      int parameterCount = null; // TODO(ahe): Compute this.
+      _MethodMirror mirror =
+          new _MethodMirror(symbol, JS('', r'$[#]', name), parameterCount);

[kasperl, 2013/05/27 12:15:33]

Create helpers for reading and writing to fields of $?

[ahe, 2013/05/27 13:55:55]

Added TODO (a big cleanup).

+      // TODO(ahe): Cache mirrors.
+      result[symbol] = mirror;
+      mirror._owner = this;
+    }
+    return result;
+  }
+
+  Map<Symbol, MethodMirror> get getters {
+    var result = new Map<Symbol, MethodMirror>();
+    // TODO(ahe): Implement this.
+    return result;
+  }
+
+  Map<Symbol, MethodMirror> get setters {
+    var result = new Map<Symbol, MethodMirror>();
+    // TODO(ahe): Implement this.
+    return result;
+  }
+
+  Map<Symbol, VariableMirror> get variables {
+    var result = new Map<Symbol, VariableMirror>();
+    // TODO(ahe): Implement this.
+    return result;
+  }
+
+  Map<Symbol, Mirror> get members {
+    Map<Symbol, Mirror> result = new Map<Symbol, Mirror>.from(classes);
+    addToResult(Symbol key, Mirror value) {
+      result[key] = value;
+    }
+    functions.forEach(addToResult);
+    getters.forEach(addToResult);
+    setters.forEach(addToResult);
+    variables.forEach(addToResult);
+    return result;
+  }
 }
 
 String _n(Symbol symbol) => _symbol_dev.Symbol.getName(symbol);
 
 Symbol _s(String name) {
   if (name == null) return null;
   return new _symbol_dev.Symbol.unvalidated(name);
 }
 
 patch MirrorSystem currentMirrorSystem() => _currentMirrorSystem;
@@ skipping 114 matching lines @@
 
 class _ClassMirror extends _ObjectMirror implements ClassMirror {
   final Symbol simpleName;
   final _jsConstructor;
   final String _fields;
   // Set as side-effect of accessing _LibraryMirror.classes.
   _LibraryMirror _owner;
 
   _ClassMirror(this.simpleName, this._jsConstructor, this._fields);
 
-  Map<Symbol, Mirror> get members {
-    var result = new Map<Symbol, Mirror>();
+  Symbol get qualifiedName => _computeQualifiedName(owner, simpleName);
+
+  Map<Symbol, MethodMirror> get functions {
+    var result = new Map<Symbol, MethodMirror>();
+    // TODO(ahe): Implement this.
+    return result;
+  }
+
+  Map<Symbol, MethodMirror> get getters {
+    var result = new Map<Symbol, MethodMirror>();
+    // TODO(ahe): Implement this.
+    return result;
+  }
+
+  Map<Symbol, MethodMirror> get setters {
+    var result = new Map<Symbol, MethodMirror>();
+    // TODO(ahe): Implement this.
+    return result;
+  }
+
+  Map<Symbol, VariableMirror> get variables {
+    var result = new Map<Symbol, VariableMirror>();
     var s = _fields.split(";");
     var fields = s[1] == "" ? [] : s[1].split(",");
     for (String field in fields) {
       _VariableMirror mirror = new _VariableMirror.from(field);
       result[mirror.simpleName] = mirror;
+      mirror._owner = this;
     }
     return result;
   }
 
+  Map<Symbol, Mirror> get members {
+    Map<Symbol, Mirror> result = new Map<Symbol, Mirror>.from(functions);
+    addToResult(Symbol key, Mirror value) {
+      result[key] = value;
+    }
+    getters.forEach(addToResult);
+    setters.forEach(addToResult);
+    variables.forEach(addToResult);
+    return result;
+  }
+
   InstanceMirror setField(Symbol fieldName, Object arg) {
     // TODO(ahe): This is extremely dangerous!!!
     JS('void', r'$[#] = #', '${_n(simpleName)}_${_n(fieldName)}', arg);
     return _reflect(arg);
   }
 
   InstanceMirror getField(Symbol fieldName) {
     // TODO(ahe): This is extremely dangerous!!!
     return _reflect(
         JS('', r'$[#]', '${_n(simpleName)}_${_n(fieldName)}'));
@@ skipping 44 matching lines @@
   }
 
   String toString() => 'ClassMirror(${_n(simpleName)})';
 }
 
 class _VariableMirror implements VariableMirror {
   // TODO(ahe): The values in these fields are virtually untested.
   final Symbol simpleName;
   final String _jsName;
   final bool _readOnly;
+  DeclarationMirror _owner;
 
   _VariableMirror(this.simpleName, this._jsName, this._readOnly);
 
   factory _VariableMirror.from(String descriptor) {
     int length = descriptor.length;
     var code = fieldCode(descriptor.codeUnitAt(length - 1));
     if (code == 0) {
       throw new RuntimeError('Bad field descriptor: $descriptor');
     }
     bool hasGetter = (code & 3) != 0;
     bool hasSetter = (code >> 2) != 0;
     String jsName;
     String accessorName = jsName = descriptor.substring(0, length - 1);
     int divider = descriptor.indexOf(":");
     if (divider > 0) {
       accessorName = accessorName.substring(0, divider);
       jsName = accessorName.substring(divider + 1);
     }
     bool readOnly = !hasSetter;
     return new _VariableMirror(_s(accessorName), jsName, readOnly);
   }
 
   TypeMirror get type => _MirrorSystem._dynamicType;
 
+  DeclarationMirror get owner => _owner;
+
+  Symbol get qualifiedName => _computeQualifiedName(owner, simpleName);
+
   static int fieldCode(int code) {
     if (code >= 60 && code <= 64) return code - 59;
     if (code >= 123 && code <= 126) return code - 117;
     if (code >= 37 && code <= 43) return code - 27;
     return 0;
   }
 }
 
 class _ClosureMirror extends _InstanceMirror implements ClosureMirror {
   _ClosureMirror(reflectee) : super(reflectee);
 
   MethodMirror get function {
     // TODO(ahe): What about optional parameters (named or not).
     var extractCallName = JS('', r'''
 function(reflectee) {
   for (var property in reflectee) {
     if ("call$" == property.substring(0, 5)) return property;
   }
   return null;
 }
 ''');
     String callName = JS('String|Null', '#(#)', extractCallName, reflectee);
     if (callName == null) {
       throw new RuntimeError('Cannot find callName on "$reflectee"');
     }
     var jsFunction = JS('', '#[#]', reflectee, callName);
     int parameterCount = int.parse(callName.split(r'$')[1]);
-    return new _MethodMirror(jsFunction, parameterCount);
+    return new _MethodMirror(_s(callName), jsFunction, parameterCount);
   }
 
   InstanceMirror apply(List positionalArguments,
                        [Map<Symbol, dynamic> namedArguments]) {
     return _reflect(
         Function.apply(reflectee, positionalArguments, namedArguments));
   }
 
   Future<InstanceMirror> applyAsync(List positionalArguments,
                                     [Map<Symbol, dynamic> namedArguments]) {
     return new Future<InstanceMirror>(
         () => apply(positionalArguments, namedArguments));
   }
 }
 
 class _MethodMirror implements MethodMirror {
+  final Symbol simpleName;
   final _jsFunction;
   final int _parameterCount;
+  DeclarationMirror _owner;
 
-  _MethodMirror(this._jsFunction, this._parameterCount);
+  _MethodMirror(this.simpleName, this._jsFunction, this._parameterCount);
 
   List<ParameterMirror> get parameters {
     // TODO(ahe): Fill the list with parameter mirrors.
     return new List<ParameterMirror>(_parameterCount);
   }
+
+  DeclarationMirror get owner => _owner;
+
+  Symbol get qualifiedName => _computeQualifiedName(owner, simpleName);
 }
+
+Symbol _computeQualifiedName(DeclarationMirror owner, Symbol simpleName) {
+  if (owner == null || _n(owner.qualifiedName) == '') return simpleName;

[kasperl, 2013/05/27 12:15:33]

Consider using ? :.

[ahe, 2013/05/27 13:55:55]

Did something else :-)

+  return _s('${_n(owner.qualifiedName)}.${_n(simpleName)}');
+}