Implement simple name and qualified name.

dart/tests/lib/mirrors/mirrors_test.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // TODO(rmacnak): Move the existing mirror tests here (a place for
 // cross-implementation tests).
 
 library MirrorsTest;
 import "dart:mirrors";
 import "../../../pkg/unittest/lib/unittest.dart";
@@ skipping 143 matching lines @@
   var classMirror = reflectClass(Class);
   expect(classMirror is ClassMirror, equals(true));
   var symbolClassMirror = reflectClass(Symbol);
   var symbolMirror = symbolClassMirror.newInstance(const Symbol(''),
                                                    ['withInitialValue']);
   var objectMirror = classMirror.newInstance(symbolMirror.reflectee,[1234]);
   expect(objectMirror.reflectee is Class, equals(true));
   expect(objectMirror.reflectee.field, equals(1234));
 }
 
-testNames(mirrors) {
+testNames(mirrors, isDart2js) {
   var libMirror = mirrors.findLibrary(const Symbol("MirrorsTest")).single;
   var classMirror = libMirror.classes[const Symbol('Class')];
   var typedefMirror = libMirror.members[const Symbol('Typedef')];
   var methodMirror = libMirror.functions[const Symbol('testNames')];
   var variableMirror = classMirror.variables[const Symbol('field')];
 
   expect(libMirror.simpleName, equals(const Symbol('MirrorsTest')));
   expect(libMirror.qualifiedName, equals(const Symbol('MirrorsTest')));
 
   expect(classMirror.simpleName, equals(const Symbol('Class')));
   expect(classMirror.qualifiedName, equals(const Symbol('MirrorsTest.Class')));
 
-  TypeVariableMirror typeVariable = classMirror.typeVariables.values.single;
-  expect(typeVariable.simpleName, equals(const Symbol('T')));
-  expect(typeVariable.qualifiedName,
-         equals(const Symbol('MirrorsTest.Class.T')));
+  if (!isDart2js) { // TODO(ahe): Implement this in dart2js.
+    TypeVariableMirror typeVariable = classMirror.typeVariables.values.single;
+    expect(typeVariable.simpleName, equals(const Symbol('T')));
+    expect(typeVariable.qualifiedName,
+           equals(const Symbol('MirrorsTest.Class.T')));
 
-  expect(typedefMirror.simpleName, equals(const Symbol('Typedef')));
-  expect(typedefMirror.qualifiedName,
-         equals(const Symbol('MirrorsTest.Typedef')));
+    expect(typedefMirror.simpleName, equals(const Symbol('Typedef')));
+    expect(typedefMirror.qualifiedName,
+           equals(const Symbol('MirrorsTest.Typedef')));
+  }
 
   expect(methodMirror.simpleName, equals(const Symbol('testNames')));
   expect(methodMirror.qualifiedName,
          equals(const Symbol('MirrorsTest.testNames')));
 
   expect(variableMirror.simpleName, equals(const Symbol('field')));
   expect(variableMirror.qualifiedName,
          equals(const Symbol('MirrorsTest.Class.field')));
 }
 
@@ skipping 12 matching lines @@
   test("Test field access", () { testFieldAccess(mirrors); });
   test("Test closure mirrors", () { testClosureMirrors(mirrors); });
   test("Test invoke constructor", () { testInvokeConstructor(mirrors); });
   test("Test current library uri", () {
     testLibraryUri(new Class(),
       (Uri uri) => uri.path.endsWith('/mirrors_test.dart'));
   });
   test("Test dart library uri", () {
     testLibraryUri("test", (Uri uri) => uri == Uri.parse('dart:core'));
   });
-  if (isDart2js) return;
+  test("Test simple and qualifiedName", () { testNames(mirrors, isDart2js); });
+  if (isDart2js) return; // TODO(ahe): Remove this line.

[kasperl, 2013/05/27 12:15:33]

Almost there.

   test("Test reflect type", () { testReflectClass(mirrors); });
-  test("Test simple and qualifiedName", () { testNames(mirrors); });
 }
 
 main() {
   mainWithArgument(isDart2js: false);
 }