Use BlobCallback in toBlob instead of FileCallback

Use BlobCallback in toBlob instead of FileCallback

Recently there's a spec change: https://github.com/whatwg/html/pull/391.

BUG=568603
Committed: https://crrev.com/b04c7518b9583a8b7d86fe9526c180b3bbfabb78
Cr-Commit-Position: refs/heads/master@{#370846}

[xlai (Olivia), 2016-01-20 17:46:15]

Description was changed from

==========
Use BlobCallback in toBlob instead of FileCallback

Recently there's a spec change: https://github.com/whatwg/html/pull/391.

BUG=568603
==========

to

==========
Use BlobCallback in toBlob instead of FileCallback

Recently there's a spec change: https://github.com/whatwg/html/pull/391.

BUG=568603
==========

[xlai (Olivia), 2016-01-20 17:46:15]

xlai@chromium.org changed reviewers:
+ junov@chromium.org, kinuko@chromium.org, philipj@opera.com

[xlai (Olivia), 2016-01-20 18:11:35]

Hi, this is a second potential solution to bug 568603 (the other code review
issue at https://codereview.chromium.org/1599413005/). This one replaces
FileCallback to BlobCallback. The original FileCallback.idl is discarded.

Recently, there's a spec change (https://github.com/whatwg/html/pull/391) about
the need to use BlobCallback in toBlob instead of FileCallback. In our current
implementation, we only have FileCallback. However, since File is a subtype of
Blob, it would be better if BlobCallback and FileCallback are just the same
callback type (It would be sad to introduce a new callback interface if it can
be avoided, as commented by philipj@ elsewhere).

@kinuko: Would you please take a look at all the files in directories
"third_party/WebKit/Source/modules/filesystem/? and
"third_party/WebKit/Source/core/fileapi/"? In particular, I change a function
signature from File to Blob in InspectorFileSystemAgent.cpp because I think it
is actually creating a Blob but forcefully casting it to File.

@junov: Everything here about toBlob are the same changes as
https://codereview.chromium.org/1599413005/. The (C) 2016 question I asked you
actually is for this code review issue, that FileCallback.h is deleted here.

@philipj: Will this solution be more conformant to the new spec change?

[kinuko, 2016-01-21 09:16:26]

On 2016/01/20 18:11:35, Olivia wrote:
> Hi, this is a second potential solution to bug 568603 (the other code review
> issue at https://codereview.chromium.org/1599413005/). This one replaces
> FileCallback to BlobCallback. The original FileCallback.idl is discarded.
> 
> Recently, there's a spec change (https://github.com/whatwg/html/pull/391)
about
> the need to use BlobCallback in toBlob instead of FileCallback. In our current
> implementation, we only have FileCallback. However, since File is a subtype of
> Blob, it would be better if BlobCallback and FileCallback are just the same
> callback type (It would be sad to introduce a new callback interface if it can
> be avoided, as commented by philipj@ elsewhere).
> 
> @kinuko: Would you please take a look at all the files in directories
> "third_party/WebKit/Source/modules/filesystem/? and
> "third_party/WebKit/Source/core/fileapi/"? In particular, I change a function
> signature from File to Blob in InspectorFileSystemAgent.cpp because I think it
> is actually creating a Blob but forcefully casting it to File.

Changes under modules/filesystem and core/fileapi lgtm.

> @junov: Everything here about toBlob are the same changes as
> https://codereview.chromium.org/1599413005/. The (C) 2016 question I asked you
> actually is for this code review issue, that FileCallback.h is deleted here.
> 
> @philipj: Will this solution be more conformant to the new spec change?

[Justin Novosad, 2016-01-21 18:31:18]

Thanks for taking care of this.
lgtm

[xlai (Olivia), 2016-01-21 21:12:32]

The CQ bit was checked by xlai@chromium.org

[xlai (Olivia), 2016-01-21 21:12:32]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
junov@chromium.org
Link to the patchset: https://codereview.chromium.org/1609313002/#ps40001
(title: "Rebase master and Renamed mimeType to contentType to match other bits
in Blob.h")

[commit-bot: I haz the power, 2016-01-21 21:13:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1609313002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1609313002/40001

[commit-bot: I haz the power, 2016-01-22 00:24:43]

Description was changed from

==========
Use BlobCallback in toBlob instead of FileCallback

Recently there's a spec change: https://github.com/whatwg/html/pull/391.

BUG=568603
==========

to

==========
Use BlobCallback in toBlob instead of FileCallback

Recently there's a spec change: https://github.com/whatwg/html/pull/391.

BUG=568603
==========

[commit-bot: I haz the power, 2016-01-22 00:24:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-22 00:25:51]

Description was changed from

==========
Use BlobCallback in toBlob instead of FileCallback

Recently there's a spec change: https://github.com/whatwg/html/pull/391.

BUG=568603
==========

to

==========
Use BlobCallback in toBlob instead of FileCallback

Recently there's a spec change: https://github.com/whatwg/html/pull/391.

BUG=568603

Committed: https://crrev.com/b04c7518b9583a8b7d86fe9526c180b3bbfabb78
Cr-Commit-Position: refs/heads/master@{#370846}
==========

[commit-bot: I haz the power, 2016-01-22 00:25:52]

Patchset 3 (id:??) landed as
https://crrev.com/b04c7518b9583a8b7d86fe9526c180b3bbfabb78
Cr-Commit-Position: refs/heads/master@{#370846}

[philipj_slow, 2016-01-28 04:27:12]

On 2016/01/20 18:11:35, Olivia wrote:
> @philipj: Will this solution be more conformant to the new spec change?

This had already landed when I saw it, so I put it on my "to check later" list.
It's not later, and this LGTM. Other than the callback function vs. callback
interface issue, this is now entirely in line with the spec AFAICT.