third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h - Issue 1609313002: Use BlobCallback in toBlob instead of FileCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h

Issue 1609313002: Use BlobCallback in toBlob instead of FileCallback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase master and Renamed mimeType to contentType to match other bits in Blob.h Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLCanvasElement.idl ('k') | third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h

diff --git a/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h b/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h

index e1b917e6be5340c26de0a138bf8416c16fb436bb..d06a8439091fd2d35ad98aa4f1d2f13cec112235 100644

--- a/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h

+++ b/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h

@@ -5,7 +5,7 @@

#include "core/CoreExport.h"

#include "core/dom/DOMTypedArray.h"

#include "core/dom/ExecutionContext.h"

-#include "core/fileapi/FileCallback.h"

+#include "core/fileapi/BlobCallback.h"

#include "platform/geometry/IntSize.h"

#include "platform/heap/Handle.h"

#include "wtf/OwnPtr.h"

@@ -20,12 +20,12 @@ class PNGImageEncoderState;

class CORE_EXPORT CanvasAsyncBlobCreator

: public RefCounted<CanvasAsyncBlobCreator> {

public:

- static PassRefPtr<CanvasAsyncBlobCreator> create(PassRefPtr<DOMUint8ClampedArray> unpremultipliedRGBAImageData, const String& mimeType, const IntSize&, FileCallback*, ExecutionContext*);

+ static PassRefPtr<CanvasAsyncBlobCreator> create(PassRefPtr<DOMUint8ClampedArray> unpremultipliedRGBAImageData, const String& mimeType, const IntSize&, BlobCallback*, ExecutionContext*);

void scheduleAsyncBlobCreation(bool canUseIdlePeriodScheduling, double quality = 0.0);

virtual ~CanvasAsyncBlobCreator();

protected:

- CanvasAsyncBlobCreator(PassRefPtr<DOMUint8ClampedArray> data, const String& mimeType, const IntSize&, FileCallback*);

+ CanvasAsyncBlobCreator(PassRefPtr<DOMUint8ClampedArray> data, const String& mimeType, const IntSize&, BlobCallback*);

virtual void scheduleCreateBlobAndCallOnMainThread();

virtual void scheduleCreateNullptrAndCallOnMainThread();

virtual void scheduleClearSelfRefOnMainThread();

@@ -42,7 +42,7 @@ private:

const IntSize m_size;

size_t m_pixelRowStride;

const String m_mimeType;

- Persistent<FileCallback> m_callback;

+ Persistent<BlobCallback> m_callback;

RefPtr<CanvasAsyncBlobCreator> m_selfRef;

void clearSelfReference();