third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h - Issue 1609313002: Use BlobCallback in toBlob instead of FileCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h

Issue 1609313002: Use BlobCallback in toBlob instead of FileCallback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase master and Renamed mimeType to contentType to match other bits in Blob.h Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/filesystem/FileEntry.idl ('k') | third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h

diff --git a/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h b/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h

index ebb7dcb85e91a655ca8ee8d0ce5e6a716a14e564..c38196c562cb10e487216d651d91acd47ce063d3 100644

--- a/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h

+++ b/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h

@@ -44,7 +44,7 @@ class DirectoryReaderBase;

class EntriesCallback;

class EntryCallback;

class ErrorCallback;

-class FileCallback;

+class BlobCallback;

class FileMetadata;

class FileSystemCallback;

class FileWriterBase;

@@ -151,14 +151,14 @@ private:

class SnapshotFileCallback final : public FileSystemCallbacksBase {

public:

- static PassOwnPtr<AsyncFileSystemCallbacks> create(DOMFileSystemBase*, const String& name, const KURL&, FileCallback*, ErrorCallback*, ExecutionContext*);

+ static PassOwnPtr<AsyncFileSystemCallbacks> create(DOMFileSystemBase*, const String& name, const KURL&, BlobCallback*, ErrorCallback*, ExecutionContext*);

virtual void didCreateSnapshotFile(const FileMetadata&, PassRefPtr<BlobDataHandle> snapshot);

private:

- SnapshotFileCallback(DOMFileSystemBase*, const String& name, const KURL&, FileCallback*, ErrorCallback*, ExecutionContext*);

+ SnapshotFileCallback(DOMFileSystemBase*, const String& name, const KURL&, BlobCallback*, ErrorCallback*, ExecutionContext*);

String m_name;

KURL m_url;

- Persistent<FileCallback> m_successCallback;

+ Persistent<BlobCallback> m_successCallback;

};

class VoidCallbacks final : public FileSystemCallbacksBase {