[turbofan] Memory improvements for escape analysis

[turbofan] Memory improvements for escape analysis

This CL reduces the memory overhead of escape analysis
by introducing a "copy on demand" strategy for virtual states
and virtual objects.

BUG=v8:4586
LOG=n

Committed: https://crrev.com/5259af606b6cca152a464def156ddd7fd6303c94
Cr-Commit-Position: refs/heads/master@{#33491}

[sigurds, 2016-01-22 09:25:45]

Description was changed from

==========
[turbofan] Memory improvements for escape analysis

This CL reduces the memory overhead of escape analysis.

BUG=v8:4586
LOG=n
==========

to

==========
[turbofan] Memory improvements for escape analysis

This CL reduces the memory overhead of escape analysis 
by introducing a "copy on demand" strategy for virtual states
and virtual objects.

BUG=v8:4586
LOG=n
==========

[sigurds, 2016-01-22 10:51:33]

sigurds@chromium.org changed reviewers:
+ jarin@chromium.org

[sigurds, 2016-01-22 10:51:33]

as just discussed, please take a look :)

[Jarin, 2016-01-22 13:36:12]

https://codereview.chromium.org/1606613002/diff/520001/src/compiler/escape-an...
File src/compiler/escape-analysis.cc (right):

https://codereview.chromium.org/1606613002/diff/520001/src/compiler/escape-an...
src/compiler/escape-analysis.cc:122: bool copy_required() const { return status_
& kCopyRequired; }
Why is has the name different style from IsInitialized?

https://codereview.chromium.org/1606613002/diff/520001/src/compiler/escape-an...
src/compiler/escape-analysis.cc:136: VirtualObjectStatus status_;
Status is not a real enum, you should use the v8::base::Flags class for this.

https://codereview.chromium.org/1606613002/diff/520001/src/compiler/escape-an...
File src/compiler/escape-analysis.h (right):

https://codereview.chromium.org/1606613002/diff/520001/src/compiler/escape-an...
src/compiler/escape-analysis.h:34: kDanglingComputed = 1u << 4,
Could we have some comments that gives some explanation for the new states? (The
old states are obvious.)

https://codereview.chromium.org/1606613002/diff/520001/src/compiler/escape-an...
src/compiler/escape-analysis.h:112: class EscapeAnalysis : private
EscapeStatusAnalysis {
Is there a good reason to inherit? Is it just to save you from writing the
accessors in this class? If yes, that I would prefer to keep the classes
separate.

[sigurds, 2016-01-25 10:34:56]

Addressed comments. PTAL again :)

https://codereview.chromium.org/1606613002/diff/520001/src/compiler/escape-an...
File src/compiler/escape-analysis.cc (right):

https://codereview.chromium.org/1606613002/diff/520001/src/compiler/escape-an...
src/compiler/escape-analysis.cc:122: bool copy_required() const { return status_
& kCopyRequired; }
On 2016/01/22 13:36:11, Jarin wrote:
> Why is has the name different style from IsInitialized?

Done.

https://codereview.chromium.org/1606613002/diff/520001/src/compiler/escape-an...
src/compiler/escape-analysis.cc:136: VirtualObjectStatus status_;
On 2016/01/22 13:36:11, Jarin wrote:
> Status is not a real enum, you should use the v8::base::Flags class for this.

Done.

https://codereview.chromium.org/1606613002/diff/520001/src/compiler/escape-an...
File src/compiler/escape-analysis.h (right):

https://codereview.chromium.org/1606613002/diff/520001/src/compiler/escape-an...
src/compiler/escape-analysis.h:34: kDanglingComputed = 1u << 4,
On 2016/01/22 13:36:11, Jarin wrote:
> Could we have some comments that gives some explanation for the new states?
(The
> old states are obvious.)

Done.

https://codereview.chromium.org/1606613002/diff/520001/src/compiler/escape-an...
src/compiler/escape-analysis.h:112: class EscapeAnalysis : private
EscapeStatusAnalysis {
On 2016/01/22 13:36:11, Jarin wrote:
> Is there a good reason to inherit? Is it just to save you from writing the
> accessors in this class? If yes, that I would prefer to keep the classes
> separate.

Done.

[Jarin, 2016-01-25 11:26:50]

lgtm

[sigurds, 2016-01-25 12:05:47]

The CQ bit was checked by sigurds@chromium.org

[sigurds, 2016-01-25 12:05:47]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/1606613002/#ps600001
(title: "Unstage for landing")

[commit-bot: I haz the power, 2016-01-25 12:05:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1606613002/600001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1606613002/600001

[commit-bot: I haz the power, 2016-01-25 12:46:29]

Description was changed from

==========
[turbofan] Memory improvements for escape analysis

This CL reduces the memory overhead of escape analysis 
by introducing a "copy on demand" strategy for virtual states
and virtual objects.

BUG=v8:4586
LOG=n
==========

to

==========
[turbofan] Memory improvements for escape analysis

This CL reduces the memory overhead of escape analysis 
by introducing a "copy on demand" strategy for virtual states
and virtual objects.

BUG=v8:4586
LOG=n
==========

[commit-bot: I haz the power, 2016-01-25 12:46:29]

Committed patchset #31 (id:600001)

[commit-bot: I haz the power, 2016-01-25 12:46:46]

Description was changed from

==========
[turbofan] Memory improvements for escape analysis

This CL reduces the memory overhead of escape analysis 
by introducing a "copy on demand" strategy for virtual states
and virtual objects.

BUG=v8:4586
LOG=n
==========

to

==========
[turbofan] Memory improvements for escape analysis

This CL reduces the memory overhead of escape analysis
by introducing a "copy on demand" strategy for virtual states
and virtual objects.

BUG=v8:4586
LOG=n

Committed: https://crrev.com/5259af606b6cca152a464def156ddd7fd6303c94
Cr-Commit-Position: refs/heads/master@{#33491}
==========

[commit-bot: I haz the power, 2016-01-25 12:46:47]

Patchset 31 (id:??) landed as
https://crrev.com/5259af606b6cca152a464def156ddd7fd6303c94
Cr-Commit-Position: refs/heads/master@{#33491}