Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Issue 1608073003: [turbofan] Add TRACE macro for escape analysis. (Closed)

Created:
4 years, 11 months ago by sigurds
Modified:
4 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add TRACE macro for escape analysis R=jarin@chromium.org BUG=v8:4586 LOG=n Committed: https://crrev.com/9b859a8891d67bee6a7e6e3b0b51c9da0a9e45c4 Cr-Commit-Position: refs/heads/master@{#33468}

Patch Set 1 #

Patch Set 2 : Improve tracing #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -203 lines) Patch
M src/compiler/escape-analysis.cc View 1 31 chunks +118 lines, -148 lines 0 comments Download
M src/compiler/escape-analysis-reducer.cc View 13 chunks +34 lines, -55 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
sigurds
PTAL
4 years, 11 months ago (2016-01-20 14:34:14 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608073003/20001
4 years, 11 months ago (2016-01-21 15:17:31 UTC) #4
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
4 years, 11 months ago (2016-01-21 15:17:32 UTC) #6
Jarin
lgtm
4 years, 11 months ago (2016-01-22 13:36:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608073003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608073003/40001
4 years, 11 months ago (2016-01-22 13:37:43 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-22 13:51:42 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 13:52:29 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9b859a8891d67bee6a7e6e3b0b51c9da0a9e45c4
Cr-Commit-Position: refs/heads/master@{#33468}

Powered by Google App Engine
This is Rietveld 408576698