Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1619103004: [turbofan] Minor performance tweaks in escape analysis (Closed)

Created:
4 years, 11 months ago by sigurds
Modified:
4 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@perf-improv-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Minor performance tweaks in escape analysis * Add caching to handling of dangling loads * Add two unittests for load elimination on escaped objects BUG=v8:4586 LOG=n Committed: https://crrev.com/2b84cb4f56f6a3ab4c61f61af0fdc75606cf15c9 Cr-Commit-Position: refs/heads/master@{#33498}

Patch Set 1 #

Patch Set 2 : Add another unittest #

Patch Set 3 : Stage #

Patch Set 4 : Unstage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -38 lines) Patch
M src/compiler/escape-analysis.cc View 1 13 chunks +26 lines, -34 lines 0 comments Download
M src/compiler/escape-analysis-reducer.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M test/unittests/compiler/escape-analysis-unittest.cc View 1 1 chunk +67 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
sigurds
PTAL
4 years, 11 months ago (2016-01-25 12:48:49 UTC) #2
Michael Starzinger
LGTM.
4 years, 11 months ago (2016-01-25 17:07:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619103004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619103004/60001
4 years, 11 months ago (2016-01-25 17:08:20 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-25 17:30:57 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 17:31:23 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2b84cb4f56f6a3ab4c61f61af0fdc75606cf15c9
Cr-Commit-Position: refs/heads/master@{#33498}

Powered by Google App Engine
This is Rietveld 408576698