bluetooth: Switch BluetoothGattCharacteristic.value to DataView

bluetooth: Switch BluetoothGattCharacteristic.value to DataView

BUG=579148
Committed: https://crrev.com/e0b2c889b851600da377b21b5e4ad7632450eb2d
Cr-Commit-Position: refs/heads/master@{#370664}

[François Beaufort, 2016-01-19 14:56:38]

Description was changed from

==========
bluetooth: Switch BluetoothGattCharacteristic.value to DataView

BUG=
==========

to

==========
bluetooth: Switch BluetoothGattCharacteristic.value to DataView

BUG=496379
==========

[fbeaufortchromium, 2016-01-19 15:02:41]

fbeaufort@chromium.org changed reviewers:
+ dominicc@chromium.org, fbeaufort@chromium.org, ortuno@chromium.org

[fbeaufortchromium, 2016-01-19 15:02:41]

As discussed in https://github.com/WebBluetoothCG/web-bluetooth/issues/172,
here's a patch that changes BluetoothGattCharacteristic.value to DataView
instead of a ArrayBuffer.

ortuno@chromium.org: Please review changes in 
third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.h
third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp
third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl

dominicc@chromium.org: Please review changes in 
third_party/WebKit/Source/core/dom/DOMDataView.h

[ortuno, 2016-01-19 18:14:34]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-19 18:14:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1603893002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1603893002/20001

[ortuno, 2016-01-19 18:44:14]

Description was changed from

==========
bluetooth: Switch BluetoothGattCharacteristic.value to DataView

BUG=496379
==========

to

==========
bluetooth: Switch BluetoothGattCharacteristic.value to DataView

BUG=579148
==========

[ortuno, 2016-01-19 18:54:36]

you probably want to change the ArrayBuffer reference in
LayoutTests/bluetooth/characteristicvaluechanged.html

Other than that LGMT

[commit-bot: I haz the power, 2016-01-19 19:26:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-19 19:26:15]

Dry run: This issue passed the CQ dry run.

[fbeaufortchromium, 2016-01-19 19:49:44]

On 2016/01/19 19:26:15, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

I've updated tests based on your feedback.

[ortuno, 2016-01-19 20:08:23]

https://codereview.chromium.org/1603893002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html
(left):

https://codereview.chromium.org/1603893002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html:27: //
assert_equals(event.target.value, value);
You should either assert the objects are the same by uncommenting the
assert_equals... or since that change is somewhat unrelated change the
ArrayBuffer reference to DataView and keep that TODO there.

https://codereview.chromium.org/1603893002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html:51: //
assert_equals(event.target.value, value);
Same here.

[fbeaufortchromium, 2016-01-19 20:52:35]

On 2016/01/19 20:08:23, ortuno wrote:
>
https://codereview.chromium.org/1603893002/diff/40001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html
> (left):
> 
>
https://codereview.chromium.org/1603893002/diff/40001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html:27:
//
> assert_equals(event.target.value, value);
> You should either assert the objects are the same by uncommenting the
> assert_equals... or since that change is somewhat unrelated change the
> ArrayBuffer reference to DataView and keep that TODO there.
> 
> 

I've kept the TODO and s/ArrayBuffer/DataView/ 

https://codereview.chromium.org/1603893002/diff/40001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html:51:
//
> assert_equals(event.target.value, value);
> Same here.

[ortuno, 2016-01-19 20:58:06]

lgtm

[fbeaufortchromium, 2016-01-20 07:51:40]

The CQ bit was checked by fbeaufort@chromium.org

[commit-bot: I haz the power, 2016-01-20 07:52:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1603893002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1603893002/60001

[commit-bot: I haz the power, 2016-01-20 08:00:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 08:00:39]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[fbeaufortchromium, 2016-01-20 10:27:09]

fbeaufort@chromium.org changed reviewers:
+ mkwst@chromium.org
- dominicc@chromium.org

[fbeaufortchromium, 2016-01-20 10:27:09]

mkwst@chromium.org: Please review changes in 
third_party/WebKit/Source/core/dom/DOMDataView.h

removing dominicc@chromium.org fom as he's travelling.

[sof, 2016-01-21 09:29:41]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2016-01-21 09:29:41]

core/dom/ lgtm

[fbeaufortchromium, 2016-01-21 09:31:14]

The CQ bit was checked by fbeaufort@chromium.org

[commit-bot: I haz the power, 2016-01-21 09:32:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1603893002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1603893002/60001

[commit-bot: I haz the power, 2016-01-21 10:36:58]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-21 10:38:06]

Description was changed from

==========
bluetooth: Switch BluetoothGattCharacteristic.value to DataView

BUG=579148
==========

to

==========
bluetooth: Switch BluetoothGattCharacteristic.value to DataView

BUG=579148

Committed: https://crrev.com/e0b2c889b851600da377b21b5e4ad7632450eb2d
Cr-Commit-Position: refs/heads/master@{#370664}
==========

[commit-bot: I haz the power, 2016-01-21 10:38:06]

Patchset 4 (id:??) landed as
https://crrev.com/e0b2c889b851600da377b21b5e4ad7632450eb2d
Cr-Commit-Position: refs/heads/master@{#370664}