Description was changed from ========== bluetooth: Switch BluetoothGattCharacteristic.value to DataView BUG= ========== to ========== bluetooth: ...
3 years, 10 months ago
(2016-01-19 14:56:38 UTC)
#1
Description was changed from
==========
bluetooth: Switch BluetoothGattCharacteristic.value to DataView
BUG=
==========
to
==========
bluetooth: Switch BluetoothGattCharacteristic.value to DataView
BUG=496379
==========
As discussed in https://github.com/WebBluetoothCG/web-bluetooth/issues/172, here's a patch that changes BluetoothGattCharacteristic.value to DataView instead of a ...
3 years, 10 months ago
(2016-01-19 15:02:41 UTC)
#3
As discussed in https://github.com/WebBluetoothCG/web-bluetooth/issues/172,
here's a patch that changes BluetoothGattCharacteristic.value to DataView
instead of a ArrayBuffer.
ortuno@chromium.org: Please review changes in
third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.h
third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp
third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl
dominicc@chromium.org: Please review changes in
third_party/WebKit/Source/core/dom/DOMDataView.h
ortuno
The CQ bit was checked by ortuno@chromium.org to run a CQ dry run
3 years, 10 months ago
(2016-01-19 18:14:34 UTC)
#4
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1603893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1603893002/20001
3 years, 10 months ago
(2016-01-19 18:14:53 UTC)
#5
Description was changed from ========== bluetooth: Switch BluetoothGattCharacteristic.value to DataView BUG=496379 ========== to ========== bluetooth: ...
3 years, 10 months ago
(2016-01-19 18:44:14 UTC)
#6
Description was changed from
==========
bluetooth: Switch BluetoothGattCharacteristic.value to DataView
BUG=496379
==========
to
==========
bluetooth: Switch BluetoothGattCharacteristic.value to DataView
BUG=579148
==========
ortuno
you probably want to change the ArrayBuffer reference in LayoutTests/bluetooth/characteristicvaluechanged.html Other than that LGMT
3 years, 10 months ago
(2016-01-19 18:54:36 UTC)
#7
you probably want to change the ArrayBuffer reference in
LayoutTests/bluetooth/characteristicvaluechanged.html
Other than that LGMT
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago
(2016-01-19 19:26:14 UTC)
#8
3 years, 10 months ago
(2016-01-19 19:26:15 UTC)
#9
Dry run: This issue passed the CQ dry run.
fbeaufortchromium
On 2016/01/19 19:26:15, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
3 years, 10 months ago
(2016-01-19 19:49:44 UTC)
#10
On 2016/01/19 19:26:15, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.
I've updated tests based on your feedback.
ortuno
https://codereview.chromium.org/1603893002/diff/40001/third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html File third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html (left): https://codereview.chromium.org/1603893002/diff/40001/third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html#oldcode27 third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html:27: // assert_equals(event.target.value, value); You should either assert the objects ...
3 years, 10 months ago
(2016-01-19 20:08:23 UTC)
#11
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1603893002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1603893002/60001
3 years, 10 months ago
(2016-01-20 07:52:42 UTC)
#15
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/137102)
3 years, 10 months ago
(2016-01-20 08:00:39 UTC)
#17
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1603893002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1603893002/60001
3 years, 10 months ago
(2016-01-21 09:32:45 UTC)
#23
3 years, 10 months ago
(2016-01-21 10:36:58 UTC)
#24
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
commit-bot: I haz the power
Description was changed from ========== bluetooth: Switch BluetoothGattCharacteristic.value to DataView BUG=579148 ========== to ========== bluetooth: ...
3 years, 10 months ago
(2016-01-21 10:38:06 UTC)
#25
Message was sent while issue was closed.
Description was changed from
==========
bluetooth: Switch BluetoothGattCharacteristic.value to DataView
BUG=579148
==========
to
==========
bluetooth: Switch BluetoothGattCharacteristic.value to DataView
BUG=579148
Committed: https://crrev.com/e0b2c889b851600da377b21b5e4ad7632450eb2d
Cr-Commit-Position: refs/heads/master@{#370664}
==========
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/e0b2c889b851600da377b21b5e4ad7632450eb2d Cr-Commit-Position: refs/heads/master@{#370664}
3 years, 10 months ago
(2016-01-21 10:38:06 UTC)
#26
Issue 1603893002: bluetooth: Switch BluetoothGattCharacteristic.value to DataView
(Closed)
Created 3 years, 10 months ago by François Beaufort
Modified 3 years, 10 months ago
Reviewers: ortuno, Mike West, fbeaufortchromium, sof
Base URL: https://chromium.googlesource.com/chromium/src.git@bluetoothValue
Comments: 2